third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp - Issue 1517693002: Accelerated filters should filter unpadded primitives.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp

Issue 1517693002: Accelerated filters should filter unpadded primitives. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Do background rect outsetting before window intersection Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/output/gl_renderer.cc ('K') | « third_party/WebKit/Source/core/paint/PaintLayer.cpp ('k') | third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp b/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp

index c9a9515f4ff8a914600750e64d5b5562c3fc0513..b7b79c3656410450041b3ac09c617307c4f5606a 100644

--- a/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp

+++ b/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp

@@ -1142,8 +1142,6 @@ void GraphicsLayer::setFilters(const FilterOperations& filters)

{

SkiaImageFilterBuilder builder;

OwnPtr<WebFilterOperations> webFilters = adoptPtr(Platform::current()->compositorSupport()->createFilterOperations());

- FilterOutsets outsets = filters.outsets();

- builder.setCropOffset(FloatSize(outsets.left(), outsets.top()));

builder.buildFilterOperations(filters, webFilters.get());

m_layer->layer()->setFilters(*webFilters);

}

@@ -1152,8 +1150,6 @@ void GraphicsLayer::setBackdropFilters(const FilterOperations& filters)

{

SkiaImageFilterBuilder builder;

OwnPtr<WebFilterOperations> webFilters = adoptPtr(Platform::current()->compositorSupport()->createFilterOperations());

- FilterOutsets outsets = filters.outsets();

- builder.setCropOffset(FloatSize(outsets.left(), outsets.top()));

builder.buildFilterOperations(filters, webFilters.get());

m_layer->layer()->setBackgroundFilters(*webFilters);

}