Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: include/v8.h

Issue 1517683002: Revert of Re-land FastAccessorBuilder. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | include/v8-experimental.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index 8834b49c57beb049407ab95b38aa1d33c4ac272a..f608cab81cae713159e649334fcadced6933bbb4 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -135,10 +135,6 @@
class CallHandlerHelper;
class EscapableHandleScope;
template<typename T> class ReturnValue;
-
-namespace experimental {
-class FastAccessorBuilder;
-} // namespace experimental
namespace internal {
class Arguments;
@@ -4423,8 +4419,7 @@
* the callback cannot be null.
*/
static Local<FunctionTemplate> NewWithFastHandler(
- Isolate* isolate, FunctionCallback callback,
- experimental::FastAccessorBuilder* fast_handler = nullptr,
+ Isolate* isolate, FunctionCallback callback, Local<Value> fast_handler,
Local<Value> data = Local<Value>(),
Local<Signature> signature = Local<Signature>(), int length = 0);
@@ -4438,9 +4433,9 @@
* callback is called whenever the function created from this
* FunctionTemplate is called.
*/
- void SetCallHandler(
- FunctionCallback callback, Local<Value> data = Local<Value>(),
- experimental::FastAccessorBuilder* fast_handler = nullptr);
+ void SetCallHandler(FunctionCallback callback,
+ Local<Value> data = Local<Value>(),
+ Local<Value> fast_handler = Local<Value>());
/** Set the predefined length property for the FunctionTemplate. */
void SetLength(int length);
« no previous file with comments | « BUILD.gn ('k') | include/v8-experimental.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698