Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: src/api-experimental.cc

Issue 1517683002: Revert of Re-land FastAccessorBuilder. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/api-experimental.h ('k') | src/compiler/fast-accessor-assembler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/api-experimental.cc
diff --git a/src/api-experimental.cc b/src/api-experimental.cc
deleted file mode 100644
index 2b49e9723a57458737561c1c26c9a3621b4639c3..0000000000000000000000000000000000000000
--- a/src/api-experimental.cc
+++ /dev/null
@@ -1,126 +0,0 @@
-// Copyright 2015 the V8 project authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-/**
- * Implementation for v8-experimental.h.
- */
-
-#include "src/api-experimental.h"
-
-#include "include/v8.h"
-#include "include/v8-experimental.h"
-#include "src/api.h"
-#include "src/compiler/fast-accessor-assembler.h"
-
-namespace {
-
-
-v8::internal::compiler::FastAccessorAssembler* FromApi(
- v8::experimental::FastAccessorBuilder* builder) {
- return reinterpret_cast<v8::internal::compiler::FastAccessorAssembler*>(
- builder);
-}
-
-
-v8::experimental::FastAccessorBuilder* FromInternal(
- v8::internal::compiler::FastAccessorAssembler* fast_accessor_assembler) {
- return reinterpret_cast<v8::experimental::FastAccessorBuilder*>(
- fast_accessor_assembler);
-}
-
-} // namespace
-
-namespace v8 {
-namespace internal {
-namespace experimental {
-
-
-MaybeHandle<Code> BuildCodeFromFastAccessorBuilder(
- v8::experimental::FastAccessorBuilder* fast_handler) {
- i::MaybeHandle<i::Code> code;
- if (fast_handler != nullptr) {
- auto faa = FromApi(fast_handler);
- code = faa->Build();
- CHECK(!code.is_null());
- delete faa;
- }
- return code;
-}
-
-} // namespace experimental
-} // namespace internal
-
-
-namespace experimental {
-
-
-FastAccessorBuilder* FastAccessorBuilder::New(Isolate* isolate) {
- i::Isolate* i_isolate = reinterpret_cast<i::Isolate*>(isolate);
- internal::compiler::FastAccessorAssembler* faa =
- new internal::compiler::FastAccessorAssembler(i_isolate);
- return FromInternal(faa);
-}
-
-
-FastAccessorBuilder::ValueId FastAccessorBuilder::IntegerConstant(
- int const_value) {
- return FromApi(this)->IntegerConstant(const_value);
-}
-
-
-FastAccessorBuilder::ValueId FastAccessorBuilder::GetReceiver() {
- return FromApi(this)->GetReceiver();
-}
-
-
-FastAccessorBuilder::ValueId FastAccessorBuilder::LoadInternalField(
- ValueId value, int field_no) {
- return FromApi(this)->LoadInternalField(value, field_no);
-}
-
-
-FastAccessorBuilder::ValueId FastAccessorBuilder::LoadValue(ValueId value_id,
- int offset) {
- return FromApi(this)->LoadValue(value_id, offset);
-}
-
-
-FastAccessorBuilder::ValueId FastAccessorBuilder::LoadObject(ValueId value_id,
- int offset) {
- return FromApi(this)->LoadObject(value_id, offset);
-}
-
-
-void FastAccessorBuilder::ReturnValue(ValueId value) {
- FromApi(this)->ReturnValue(value);
-}
-
-
-void FastAccessorBuilder::CheckFlagSetOrReturnNull(ValueId value_id, int mask) {
- FromApi(this)->CheckFlagSetOrReturnNull(value_id, mask);
-}
-
-
-void FastAccessorBuilder::CheckNotZeroOrReturnNull(ValueId value_id) {
- FromApi(this)->CheckNotZeroOrReturnNull(value_id);
-}
-
-
-FastAccessorBuilder::LabelId FastAccessorBuilder::MakeLabel() {
- return FromApi(this)->MakeLabel();
-}
-
-
-void FastAccessorBuilder::SetLabel(LabelId label_id) {
- FromApi(this)->SetLabel(label_id);
-}
-
-
-void FastAccessorBuilder::CheckNotZeroOrJump(ValueId value_id,
- LabelId label_id) {
- FromApi(this)->CheckNotZeroOrJump(value_id, label_id);
-}
-
-} // namespace experimental
-} // namespace v8
« no previous file with comments | « src/api-experimental.h ('k') | src/compiler/fast-accessor-assembler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698