Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1517683002: Revert of Re-land FastAccessorBuilder. (Closed)

Created:
5 years ago by vogelheim
Modified:
5 years ago
CC:
Paweł Hajdan Jr., v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Re-land FastAccessorBuilder. (patchset #2 id:20001 of https://codereview.chromium.org/1504713012/ ) Reason for revert: Meeh. Now "V8 Linux - gcmole" bot has issues; apparently due to a somewhat exotic builder configuration. Original issue's description: > Re-land FastAccessorBuilder. > > ... using the RawMachineAssembler and the work in crrev.com/1407313004. > > The original change collided with crrev.com/1513543003. > > BUG=chromium:508898 > LOG=Y > > Committed: https://crrev.com/515d9ccd8e6df7bf2ca01e2a55aaad30226399e1 > Cr-Commit-Position: refs/heads/master@{#32742} > > patch from issue 1474543004 at patchset 260001 (http://crrev.com/1474543004#ps260001) > > Committed: https://crrev.com/ee5c38d7db907ff86dd4049721c0cb4bc90a6c4d > Cr-Commit-Position: refs/heads/master@{#32753} TBR=epertoso@chromium.org,mstarzinger@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:508898 Committed: https://crrev.com/f564231a6bb83d15177d24ed9c7771be7a031932 Cr-Commit-Position: refs/heads/master@{#32754}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -855 lines) Patch
M BUILD.gn View 3 chunks +0 lines, -5 lines 0 comments Download
M include/v8.h View 3 chunks +4 lines, -9 lines 0 comments Download
D include/v8-experimental.h View 1 chunk +0 lines, -53 lines 0 comments Download
M src/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M src/api.cc View 6 chunks +13 lines, -16 lines 0 comments Download
D src/api-experimental.h View 1 chunk +0 lines, -28 lines 0 comments Download
D src/api-experimental.cc View 1 chunk +0 lines, -126 lines 0 comments Download
D src/compiler/fast-accessor-assembler.h View 1 chunk +0 lines, -106 lines 0 comments Download
D src/compiler/fast-accessor-assembler.cc View 1 chunk +0 lines, -223 lines 0 comments Download
M test/cctest/cctest.h View 1 chunk +0 lines, -6 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D test/cctest/test-api-fast-accessor-builder.cc View 1 chunk +0 lines, -274 lines 0 comments Download
M tools/gyp/v8.gyp View 3 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
vogelheim
Created Revert of Re-land FastAccessorBuilder.
5 years ago (2015-12-10 14:44:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1517683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1517683002/1
5 years ago (2015-12-10 14:44:53 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 14:45:19 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-10 14:46:02 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f564231a6bb83d15177d24ed9c7771be7a031932
Cr-Commit-Position: refs/heads/master@{#32754}

Powered by Google App Engine
This is Rietveld 408576698