src/full-codegen/x64/full-codegen-x64.cc - Issue 1517673002: Fix Object.prototype.toString.call(proxy)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/x64/full-codegen-x64.cc

Issue 1517673002: Fix Object.prototype.toString.call(proxy) (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Add test Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/x64/full-codegen-x64.cc

diff --git a/src/full-codegen/x64/full-codegen-x64.cc b/src/full-codegen/x64/full-codegen-x64.cc

index 961cefa4f52404982174e120bc40ede50f7e1538..7c16e0aa40687ecc8a7fa653234f7619c1cf42dd 100644

--- a/src/full-codegen/x64/full-codegen-x64.cc

+++ b/src/full-codegen/x64/full-codegen-x64.cc

@@ -3208,9 +3208,6 @@ void FullCodeGenerator::EmitClassOf(CallRuntime* expr) {

__ CmpObjectType(rax, FIRST_JS_RECEIVER_TYPE, rax);

// Map is now in rax.

__ j(below, &null);

- STATIC_ASSERT(FIRST_NONCALLABLE_SPEC_OBJECT_TYPE ==

- FIRST_JS_RECEIVER_TYPE + 1);

- __ j(equal, &function);

__ CmpInstanceType(rax, LAST_JS_RECEIVER_TYPE);

STATIC_ASSERT(LAST_NONCALLABLE_SPEC_OBJECT_TYPE ==