Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 1517643002: PlzNavigate: Add helper method for checking if PlzNavigate is enabled. (Closed)

Created:
5 years ago by carlosk
Modified:
5 years ago
Reviewers:
Devlin, brettw, nasko, mmenke
CC:
chromium-reviews, asanka, jsbell+serviceworker_chromium.org, serviceworker-reviews, creis+watch_chromium.org, mlamouri+watch-content_chromium.org, tzik, horo+watch_chromium.org, nasko+codewatch_chromium.org, jam, nhiroki, mkwst+moarreviews-renderer_chromium.org, blink-worker-reviews_chromium.org, darin-cc_chromium.org, michaeln, devtools-reviews_chromium.org, loading-reviews_chromium.org, kinuko+serviceworker, kinuko+watch, pfeldman, clamy
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PlzNavigate: Add helper method for checking if PlzNavigate is enabled. In the interest of simplifying the code for checking if browser side navigation is enabled this change creates a new helper method and replaces all current occurrences of the "extended" form. BUG=368813 TBR=mmenke@chromium.org Committed: https://crrev.com/d80262f530419ce91eedddff4347949875b5db92 Cr-Commit-Position: refs/heads/master@{#365527}

Patch Set 1 #

Patch Set 2 : Fixed build errors. #

Patch Set 3 : Another build error fix. #

Total comments: 4

Patch Set 4 : Moved PlzNavigate policy file to content/public/common. #

Patch Set 5 : Rebase. #

Patch Set 6 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -299 lines) Patch
M chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc View 1 2 3 3 chunks +3 lines, -6 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 1 2 3 3 chunks +2 lines, -4 lines 0 comments Download
M content/browser/download/download_request_handle.cc View 1 2 3 4 4 chunks +3 lines, -6 lines 0 comments Download
M content/browser/frame_host/frame_tree_node.cc View 1 2 3 4 6 chunks +5 lines, -11 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl_unittest.cc View 1 2 3 4 5 6 chunks +5 lines, -11 lines 0 comments Download
M content/browser/frame_host/navigation_handle_impl.cc View 1 2 3 4 5 4 chunks +4 lines, -11 lines 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 1 2 3 4 5 10 chunks +9 lines, -20 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 2 3 4 11 chunks +11 lines, -22 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 1 2 3 4 5 11 chunks +11 lines, -22 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager_unittest.cc View 1 2 3 6 chunks +7 lines, -13 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 2 3 4 8 chunks +9 lines, -16 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_unittest.cc View 1 2 3 7 chunks +6 lines, -12 lines 0 comments Download
M content/browser/loader/resource_request_info_impl.cc View 1 2 3 3 chunks +2 lines, -4 lines 0 comments Download
M content/browser/security_exploit_browsertest.cc View 1 2 3 2 chunks +4 lines, -6 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.cc View 1 2 3 3 chunks +2 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host.cc View 1 2 3 5 chunks +4 lines, -8 lines 0 comments Download
M content/browser/service_worker/service_worker_request_handler.cc View 1 2 3 6 chunks +5 lines, -10 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 1 2 3 4 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc View 1 2 3 2 chunks +4 lines, -6 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_unittest.cc View 1 2 3 4 5 8 chunks +8 lines, -19 lines 0 comments Download
M content/child/service_worker/service_worker_network_provider.cc View 1 2 3 2 chunks +2 lines, -5 lines 0 comments Download
M content/child/web_url_loader_impl.cc View 1 2 3 5 chunks +4 lines, -9 lines 0 comments Download
M content/common/navigation_params.cc View 1 2 3 4 5 1 chunk +2 lines, -4 lines 0 comments Download
M content/content_common.gypi View 1 2 3 4 3 chunks +5 lines, -3 lines 0 comments Download
A content/public/common/browser_side_navigation_policy.h View 1 2 3 1 chunk +21 lines, -0 lines 0 comments Download
A + content/public/common/browser_side_navigation_policy.cc View 1 2 3 1 chunk +3 lines, -4 lines 0 comments Download
M content/public/test/test_renderer_host.cc View 1 2 3 3 chunks +3 lines, -8 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 4 5 6 chunks +6 lines, -11 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M content/test/test_render_frame.cc View 1 2 3 2 chunks +2 lines, -4 lines 0 comments Download
M content/test/test_render_frame_host.cc View 1 2 3 4 5 9 chunks +8 lines, -17 lines 0 comments Download
M content/test/test_web_contents.cc View 1 2 3 6 chunks +5 lines, -11 lines 0 comments Download
M extensions/browser/api/app_window/app_window_api.cc View 1 2 3 2 chunks +2 lines, -3 lines 0 comments Download
M extensions/browser/app_window/app_window.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 24 (11 generated)
carlosk
nasko@: PTAL. This simplifies all checks for PlzNavigate and removes about 100 LoC around them. ...
5 years ago (2015-12-10 09:57:24 UTC) #2
nasko
Why not make the method content/public and remove all command line checks in the codebase? ...
5 years ago (2015-12-11 01:02:46 UTC) #3
carlosk
On 2015/12/11 01:02:46, nasko wrote: > Why not make the method content/public and remove all ...
5 years ago (2015-12-11 13:40:37 UTC) #4
nasko
LGTM
5 years ago (2015-12-11 19:32:22 UTC) #5
carlosk
Thanks nasko@. brettw@: PTAL at: - chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc - extensions/browser/api/app_window/app_window_api.cc - extensions/browser/app_window/app_window.cc
5 years ago (2015-12-14 14:32:07 UTC) #7
carlosk
Adding reviewers that are owners closer to the files being changed: mmenke@ PTAL at: chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc ...
5 years ago (2015-12-15 14:00:13 UTC) #9
Devlin
extensions RS LGTM
5 years ago (2015-12-15 17:24:40 UTC) #10
carlosk
Thanks. I'm TBR-ing for the remaining file and hitting commit now.
5 years ago (2015-12-16 09:57:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1517643002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1517643002/80001
5 years ago (2015-12-16 09:58:05 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/129459)
5 years ago (2015-12-16 10:02:52 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1517643002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1517643002/100001
5 years ago (2015-12-16 13:26:14 UTC) #20
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years ago (2015-12-16 14:40:43 UTC) #22
commit-bot: I haz the power
5 years ago (2015-12-16 14:41:44 UTC) #24
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/d80262f530419ce91eedddff4347949875b5db92
Cr-Commit-Position: refs/heads/master@{#365527}

Powered by Google App Engine
This is Rietveld 408576698