Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1517623002: Turn an if in ~PrintPreviewDistiller() that's always true to a DCHECK. (Closed)

Created:
5 years ago by Lei Zhang
Modified:
5 years ago
Reviewers:
arjunpatel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Turn an if in ~PrintPreviewDistiller() that's always true to a DCHECK. Committed: https://crrev.com/5b261f85dcb6bcf04a37830c6200e4ea8f06eab8 Cr-Commit-Position: refs/heads/master@{#364453}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M chrome/browser/ui/webui/print_preview/print_preview_distiller.cc View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Lei Zhang
5 years ago (2015-12-10 03:33:59 UTC) #2
arjunpatel
LGTM
5 years ago (2015-12-10 16:53:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1517623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1517623002/1
5 years ago (2015-12-10 18:52:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 20:13:20 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-10 20:14:31 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5b261f85dcb6bcf04a37830c6200e4ea8f06eab8
Cr-Commit-Position: refs/heads/master@{#364453}

Powered by Google App Engine
This is Rietveld 408576698