Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1517613003: Bugfix: type feedback vector should allocate *before* changing internal state. (Closed)

Created:
5 years ago by mvstanton
Modified:
5 years ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Bugfix: type feedback vector should allocate *before* changing internal state. An allocation can reenter type feedback code because of a triggered GC. Make sure the vector state remains coherent at these points. BUG=568524 LOG=N Committed: https://crrev.com/45fc8f4c09937f173144cdeb0a32d41d1c6ef8d0 Cr-Commit-Position: refs/heads/master@{#32766}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/type-feedback-vector.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mvstanton
Hi Igor, Here is the fix. I thought about introducing NoAllocation scopes during vector manipulation, ...
5 years ago (2015-12-10 16:22:01 UTC) #2
Igor Sheludko
lgtm
5 years ago (2015-12-10 17:23:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1517613003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1517613003/1
5 years ago (2015-12-10 17:36:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 17:39:56 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-10 17:40:19 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/45fc8f4c09937f173144cdeb0a32d41d1c6ef8d0
Cr-Commit-Position: refs/heads/master@{#32766}

Powered by Google App Engine
This is Rietveld 408576698