Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 1517593003: [turbofan] Optimize JSCallConstruct in typed lowering to direct calls. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Optimize JSCallConstruct in typed lowering to direct calls. Lower JSCallConstruct with known target JSFunction to a direct call to the target's construct_stub, and JSCallConstruct with function target to direct call to ConstructFunction builtin. R=jarin@chromium.org Committed: https://crrev.com/66f934efa1741526d8fae5b2175bda24f8397d74 Cr-Commit-Position: refs/heads/master@{#32735}

Patch Set 1 #

Patch Set 2 : Fix arm typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -0 lines) Patch
M src/arm/interface-descriptors-arm.cc View 1 1 chunk +11 lines, -0 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/code-factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/code-factory.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +62 lines, -0 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/interface-descriptors.h View 2 chunks +8 lines, -0 lines 0 comments Download
M src/interface-descriptors.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
5 years ago (2015-12-10 05:11:39 UTC) #1
Benedikt Meurer
Hey Jaro, Here's some simple optimization for call construct when inlining wasn't possible. Please take ...
5 years ago (2015-12-10 05:14:24 UTC) #2
Jarin
lgtm
5 years ago (2015-12-10 05:29:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1517593003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1517593003/20001
5 years ago (2015-12-10 05:29:42 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-10 06:03:44 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-10 06:03:58 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/66f934efa1741526d8fae5b2175bda24f8397d74
Cr-Commit-Position: refs/heads/master@{#32735}

Powered by Google App Engine
This is Rietveld 408576698