Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1517593002: Revert of CT Verify test utilities change - Moved the following common functions (Closed)

Created:
5 years ago by ramant (doing other things)
Modified:
5 years ago
CC:
chromium-reviews, certificate-transparency-chrome_googlegroups.com, cbentzel+watch_chromium.org, Eran Messeri
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of CT Verify test utilities change - Moved the following common functions (patchset #1 id:1 of https://codereview.chromium.org/1498983004/ ) Reason for revert: net_unittests fails half the time on Android Cronet Builder (dbg). BUG=568282 Original issue's description: > CT Verify test utilities change - Moved the following common functions > between ProofVerifierChromiumTest and MultiLogCTVerifierTest into > ct_test_utils.cc. > > GetSCTListForTesting() > GetSCTListWithInvalidSCT() > CheckForSingleVerifiedSCTInResult(...) > CheckForSCTOrigin(...) > > R=eranm@chromium.org, rch@chromium.org > > Committed: https://crrev.com/6486d0d7c119576d0ead5e55c41b2269a4b01cfc > Cr-Commit-Position: refs/heads/master@{#363494} TBR=eranm@chromium.org,rch@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/13cb74df2cc9b14ab70598d80241a5ec919ca688 Cr-Commit-Position: refs/heads/master@{#364205}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -67 lines) Patch
M net/cert/multi_log_ct_verifier_unittest.cc View 5 chunks +41 lines, -10 lines 0 comments Download
M net/quic/crypto/proof_verifier_chromium_test.cc View 3 chunks +31 lines, -5 lines 0 comments Download
M net/test/ct_test_util.h View 2 chunks +1 line, -19 lines 0 comments Download
M net/test/ct_test_util.cc View 2 chunks +1 line, -33 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ramant (doing other things)
Created Revert of CT Verify test utilities change - Moved the following common functions
5 years ago (2015-12-09 23:14:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1517593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1517593002/1
5 years ago (2015-12-09 23:16:24 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-09 23:18:57 UTC) #4
commit-bot: I haz the power
5 years ago (2015-12-09 23:19:52 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/13cb74df2cc9b14ab70598d80241a5ec919ca688
Cr-Commit-Position: refs/heads/master@{#364205}

Powered by Google App Engine
This is Rietveld 408576698