Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1517583004: Roll buildtools b747a9e091..68e3c238a5 (Closed)

Created:
5 years ago by brettw
Modified:
5 years ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll buildtools b747a9e091..68e3c238a5 In order to roll GN 7c3f6cc650..e33d0667da (r363049:r364398) and pick up the following changes: 936b61a No GN phony rules when it matches outputs. 22d5fac tools/gn: depend on allocator_extension.cc to keep bootstrap working 90cdb30 Reference configs variable from config help in GN dda6c27 Remove allocator_extension_thunks since this layer is not required 79adad4 Format all BUILD.gn with "gn format --in-place". 0cbfc07f6 tools/gn: update reference.md doc 910ac44 [GN] Add support to rebase_path to resolve paths above the source root. 7741ab4 tools/gn: forward declare some base types in trace.h TBR=dpranke@chromium.org CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_dbg;tryserver.chromium.win:win8_chromium_gn_dbg,win_chromium_gn_x64_rel Committed: https://crrev.com/7d8337726631f74c1310fa65bd4f504e9d3d352f Cr-Commit-Position: refs/heads/master@{#364508}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
brettw
5 years ago (2015-12-10 18:26:19 UTC) #1
Dirk Pranke
lgtm
5 years ago (2015-12-10 18:27:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1517583004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1517583004/1
5 years ago (2015-12-10 18:28:15 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/108826)
5 years ago (2015-12-10 20:52:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1517583004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1517583004/1
5 years ago (2015-12-10 21:04:54 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 22:36:53 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-10 22:37:30 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d8337726631f74c1310fa65bd4f504e9d3d352f
Cr-Commit-Position: refs/heads/master@{#364508}

Powered by Google App Engine
This is Rietveld 408576698