Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1517243003: [Android] Add a presubmit for devil/. (Closed)

Created:
5 years ago by jbudorick
Modified:
5 years ago
CC:
chromium-reviews, klundberg+watch_chromium.org, mikecase+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Add a presubmit for devil/. BUG=476719 Committed: https://crrev.com/a83d25fbaac0f8a92538a79af87bdedc0f888233 Cr-Commit-Position: refs/heads/master@{#365107}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -21 lines) Patch
M build/android/PRESUBMIT.py View 2 chunks +2 lines, -22 lines 0 comments Download
A build/android/devil/PRESUBMIT.py View 1 chunk +87 lines, -0 lines 0 comments Download
A + build/android/devil/pylintrc View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jbudorick
5 years ago (2015-12-11 20:01:03 UTC) #2
jbudorick
On 2015/12/11 20:01:03, jbudorick wrote: ping
5 years ago (2015-12-14 20:05:03 UTC) #3
rnephew (Reviews Here)
On 2015/12/14 20:05:03, jbudorick wrote: > On 2015/12/11 20:01:03, jbudorick wrote: > > ping lgtm
5 years ago (2015-12-14 20:10:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1517243003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1517243003/1
5 years ago (2015-12-14 20:11:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-14 22:12:24 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-14 22:13:18 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a83d25fbaac0f8a92538a79af87bdedc0f888233
Cr-Commit-Position: refs/heads/master@{#365107}

Powered by Google App Engine
This is Rietveld 408576698