Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1517213002: GN: Fix incorrect android toolchain value for arm64 and mips64el (Closed)

Created:
5 years ago by agrieve
Modified:
5 years ago
Reviewers:
Yaron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Fix incorrect android toolchain value for arm64 and mips64el BUG=568883 Committed: https://crrev.com/57933b7928005cd5f29d42f419b7c14a322b5c4e Cr-Commit-Position: refs/heads/master@{#364718}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M build/config/android/config.gni View 1 chunk +2 lines, -2 lines 0 comments Download
M build/toolchain/android/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
agrieve
On 2015/12/11 13:21:16, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:yfriedman@chromium.org ◐ o ◑
5 years ago (2015-12-11 13:21:21 UTC) #3
Yaron
lgtm
5 years ago (2015-12-11 14:58:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1517213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1517213002/1
5 years ago (2015-12-11 15:33:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-11 16:49:04 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-11 16:50:01 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/57933b7928005cd5f29d42f419b7c14a322b5c4e
Cr-Commit-Position: refs/heads/master@{#364718}

Powered by Google App Engine
This is Rietveld 408576698