Issue 15172003: Preallocate transitioned maps for TypedArrays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15172003: Preallocate transitioned maps for TypedArrays. (Closed)

Created:
7 years, 7 months ago by Dmitry Lomov (no reviews)

Modified:
7 years, 7 months ago

Reviewers:
Hannes Payer (out of office), Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Preallocate transitioned maps for TypedArrays. R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14693

Patch Set 1 : #

Total comments: 1

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+174 lines, -58 lines)			Patch
M	include/v8.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/api.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/bootstrapper.cc	View	19 chunks	+53 lines, -35 lines	0 comments	Download
M	src/heap.h	View	3 chunks	+21 lines, -0 lines	1 comment	Download
M	src/heap.cc	View	4 chunks	+88 lines, -1 line	0 comments	Download
M	src/objects-inl.h	View	1 chunk	+11 lines, -4 lines	0 comments	Download
M	src/runtime.cc	View	2 chunks	+0 lines, -13 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Dmitry Lomov (no reviews)

Michael/Hannes, please take a look. Not transitioning on every allocation shaves about 10% off typed ...

7 years, 7 months ago (2013-05-14 16:25:34 UTC) #1

Hannes Payer (out of office)

LGTM! one nit from my side. https://codereview.chromium.org/15172003/diff/2001/src/heap.h File src/heap.h (right): https://codereview.chromium.org/15172003/diff/2001/src/heap.h#newcode141 src/heap.h:141: EmptyExternalPixelArray) \ Can ...

7 years, 7 months ago (2013-05-15 14:14:16 UTC) #2

Dmitry Lomov (no reviews)

7 years, 7 months ago (2013-05-15 15:24:02 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r14693 (presubmit successful).

Expand Messages | Collapse Messages