Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1123)

Issue 1517173002: Rewrite IOSink documentation, plus some clean-up. (Closed)

Created:
5 years ago by Lasse Reichstein Nielsen
Modified:
5 years ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -55 lines) Patch
M sdk/lib/io/io_sink.dart View 10 chunks +56 lines, -55 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Lasse Reichstein Nielsen
5 years ago (2015-12-11 07:41:31 UTC) #2
floitsch
LGTM! thanks.
5 years ago (2015-12-11 08:18:41 UTC) #3
floitsch
Please close http://dartbug.com/25196 when you commit (assuming you agree with my comment there).
5 years ago (2015-12-11 08:19:19 UTC) #4
Lasse Reichstein Nielsen
5 years ago (2015-12-11 09:10:44 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ea55dc9bec24b5318bfef721c64e99c7eeb08875 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698