Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 1517153004: Introduce experimental flag --reify in the vm. (Closed)

Created:
5 years ago by regis
Modified:
4 years, 9 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Introduce experimental flag --reify in the vm. Note that many tests will fail when using --no-reify, since expected type errors are not reported. R=iposva@google.com Committed: https://github.com/dart-lang/sdk/commit/699890db11b3dfc515fd5dc1e7b94aca5432cd18

Patch Set 1 #

Patch Set 2 : sync #

Patch Set 3 : sync #

Patch Set 4 : sync #

Patch Set 5 : update after source fingerprints are made insensitive to types #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M runtime/vm/class_finalizer.cc View 1 2 3 4 3 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
regis
5 years ago (2015-12-11 23:16:02 UTC) #2
regis
This can now be submitted after source fingerprints have been made insensitive to types (see ...
4 years, 9 months ago (2016-02-29 23:08:38 UTC) #4
Ivan Posva
LGTM -ip
4 years, 9 months ago (2016-03-01 18:00:16 UTC) #5
regis
4 years, 9 months ago (2016-03-01 18:03:24 UTC) #7
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
699890db11b3dfc515fd5dc1e7b94aca5432cd18 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698