Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 1517143002: [Android] Move install_commands to devil/. (Closed)

Created:
5 years ago by jbudorick
Modified:
5 years ago
CC:
chromium-reviews, klundberg+watch_chromium.org, mikecase+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Move install_commands to devil/. BUG=560559 Committed: https://crrev.com/1cea58aa62c7741d4ac8f17d190e84da67c57325 Cr-Commit-Position: refs/heads/master@{#364710}

Patch Set 1 #

Patch Set 2 : --no-find-copies #

Total comments: 1

Patch Set 3 : android_file_system -> file_system #

Patch Set 4 : --no-find-copies again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -70 lines) Patch
A + build/android/devil/android/constants/__init__.py View 1 1 chunk +1 line, -1 line 0 comments Download
A build/android/devil/android/constants/file_system.py View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M build/android/devil/android/device_utils.py View 2 chunks +1 line, -1 line 0 comments Download
A + build/android/devil/android/install_commands.py View 1 2 3 chunks +6 lines, -7 lines 0 comments Download
M build/android/devil/devil_dependencies.json View 1 chunk +10 lines, -0 lines 0 comments Download
D build/android/pylib/device/commands/__init__.py View 1 chunk +0 lines, -3 lines 0 comments Download
D build/android/pylib/device/commands/install_commands.py View 1 chunk +0 lines, -58 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
jbudorick
5 years ago (2015-12-11 04:53:24 UTC) #2
rnephew (Wrong account)
lgtm https://codereview.chromium.org/1517143002/diff/20001/build/android/devil/android/install_commands.py File build/android/devil/android/install_commands.py (right): https://codereview.chromium.org/1517143002/diff/20001/build/android/devil/android/install_commands.py#newcode39 build/android/devil/android/install_commands.py:39: chromium_commands_jar_path = devil_env.config.FetchPath('chromium_commands') I'm going to have to ...
5 years ago (2015-12-11 05:13:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1517143002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1517143002/60001
5 years ago (2015-12-11 14:40:32 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years ago (2015-12-11 16:07:02 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-11 16:08:36 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/1cea58aa62c7741d4ac8f17d190e84da67c57325
Cr-Commit-Position: refs/heads/master@{#364710}

Powered by Google App Engine
This is Rietveld 408576698