Clean up dependencies on X11 libraries

Clean up dependencies on X11 libraries

This converts the remaining targets that depend on X11 libraries over to
depending on targets from build/linux/system.gyp instead of adding the
libraries manually to the link line. This ensures that the link line is
generated with pkg-config and makes the dependencies a bit tighter by
getting rid of the all_dependent_settings entry in ui/ui.gyp

BUG=339518
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250311

[jamesr, 2014-02-07 02:43:48]

phadjan.jr@ - could you please review this patch? if it links on the bots it's
probably fine but is worth checking over

sky/piman@ - could you OWNERS approve the chrome/+ui/ and gpu/+ui/gl/ changes,
respectively?

This should enable dropping the ui/ui.gyp:ui dependency from gpu/, but I'll land
that separately so that if it breaks some obscure config like it did last time
we can revert only that small patch and not these other cleanups.

[piman, 2014-02-07 03:36:28]

lgtm

[sky, 2014-02-07 17:22:26]

LGTM

[Paweł Hajdan Jr., 2014-02-07 23:09:28]

LGTM with non-blocking comments.

https://codereview.chromium.org/151713003/diff/1/build/linux/system.gyp
File build/linux/system.gyp (right):

https://codereview.chromium.org/151713003/diff/1/build/linux/system.gyp#newco...
build/linux/system.gyp:299: 'dependencies': [
In theory this shouldn't be needed. pkg-config files for glib should handle that
if this is really a dependency of glib.

Up to you, but if you'd like to take a closer look maybe try removing it and see
what happens. If some target fails to compile now, it may be better to add an
explicit dependency on libXtst to that target.

https://codereview.chromium.org/151713003/diff/1/build/linux/system.gyp#newco...
build/linux/system.gyp:974: ['_toolset=="target"', {
This seems to be doing exactly the same thing in both branches. Is this
expected? Maybe the idea is to have these expand to something different in both
cases, but it looks a bit suspicious.

https://codereview.chromium.org/151713003/diff/1/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (left):

https://codereview.chromium.org/151713003/diff/1/chrome/chrome_browser.gypi#o...
chrome/chrome_browser.gypi:3094: ['os_posix == 1 and OS != "mac" and OS != "ios"
and OS != "android"', {
Nice cleanup. :)

[piman, 2014-02-07 23:33:28]

https://codereview.chromium.org/151713003/diff/1/build/linux/system.gyp
File build/linux/system.gyp (right):

https://codereview.chromium.org/151713003/diff/1/build/linux/system.gyp#newco...
build/linux/system.gyp:974: ['_toolset=="target"', {
On 2014/02/07 23:09:28, Paweł Hajdan Jr. wrote:
> This seems to be doing exactly the same thing in both branches. Is this
> expected? Maybe the idea is to have these expand to something different in
both
> cases, but it looks a bit suspicious.

It's not... <(pkg-config) vs pkg-config (target pkg-config that uses the sysroot
vs host pkg-config, that doesn't)

[jamesr, 2014-02-10 22:26:32]

On 2014/02/07 23:09:28, Paweł Hajdan Jr. wrote:
>
https://codereview.chromium.org/151713003/diff/1/build/linux/system.gyp#newco...
> build/linux/system.gyp:299: 'dependencies': [
> In theory this shouldn't be needed. pkg-config files for glib should handle
that
> if this is really a dependency of glib.
> 
> Up to you, but if you'd like to take a closer look maybe try removing it and
see
> what happens. If some target fails to compile now, it may be better to add an
> explicit dependency on libXtst to that target.

interactive_ui_tests fails to link without this dependency:

../../chrome/browser/extensions/extension_commands_global_registry_apitest.cc:48:
error: undefined reference to 'XTestFakeKeyEvent'

I think the correct answer is probably for this target (and whichever others
need libXtst) to declare a dependency on libXtst themselves, but I'd like to try
to fix that dependency as a follow-up to this patch to minimize the chance of
breaking something else.

[jamesr, 2014-02-10 22:26:37]

The CQ bit was checked by jamesr@chromium.org

[commit-bot: I haz the power, 2014-02-10 22:27:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/151713003/1

[commit-bot: I haz the power, 2014-02-10 22:57:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/151713003/1

[jamesr, 2014-02-10 23:46:44]

The CQ bit was unchecked by jamesr@chromium.org

[jamesr, 2014-02-10 23:47:00]

Unchecking CQ - there are a few more x11 dependencies in chromeos=1 builds.

[jamesr, 2014-02-10 23:51:36]

The CQ bit was checked by jamesr@chromium.org

[commit-bot: I haz the power, 2014-02-10 23:52:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/151713003/1

[commit-bot: I haz the power, 2014-02-10 23:53:46]

Failed to trigger a try job on mac_rel
HTTP Error 400: Bad Request

[commit-bot: I haz the power, 2014-02-11 00:06:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/151713003/400001

[commit-bot: I haz the power, 2014-02-11 03:38:13]

Change committed as 250311