Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1517103003:
Disable VS 2015 warning about global constructor (Closed)
|
Created:
5 years ago by brucedawson Modified:
5 years ago Reviewers:
vabr (Chromium) CC:
chromium-reviews, rouslan+autofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, sebsg Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisable VS 2015 warning about global constructor
Having std::vector as a global variable means that constructors and
destructors will run at startup and shutdown, which can be problematic.
This also triggered a (buggy) VS 2015 warning, which this change
disables for this source file.
The VS 2015 warning bug is discussed by a VC++ compiler dev in one of
the answers to this question:
http://stackoverflow.com/questions/34013930/error-c4592-symbol-will-be-dynamically-initialized-vs2015-1-static-const-std
TBR=vabr@chromium.org
BUG=440500
Committed: https://crrev.com/f7199714336c7fa05b465b9b5ba051999566b657
Cr-Commit-Position: refs/heads/master@{#364927}
Patch Set 1 #Patch Set 2 : Added necessary #ifdefs #Messages
Total messages: 20 (11 generated)
Description was changed from ========== Disable VS 2015 warning about global constructor Having std::vector as a global variable means that constructors and destructors will run at startup and shutdown, which can be problematic. This also triggered a (buggy) VS 2015 warning, which this change disables for this source file. The VS 2015 warning bug is discussed by a VC++ compiler dev in one of the answers to this question: http://stackoverflow.com/questions/34013930/error-c4592-symbol-will-be-dynami... BUG=440500 ========== to ========== Disable VS 2015 warning about global constructor Having std::vector as a global variable means that constructors and destructors will run at startup and shutdown, which can be problematic. This also triggered a (buggy) VS 2015 warning, which this change disables for this source file. The VS 2015 warning bug is discussed by a VC++ compiler dev in one of the answers to this question: http://stackoverflow.com/questions/34013930/error-c4592-symbol-will-be-dynami... TBR=sebsg@chromium.org BUG=440500 ==========
Description was changed from ========== Disable VS 2015 warning about global constructor Having std::vector as a global variable means that constructors and destructors will run at startup and shutdown, which can be problematic. This also triggered a (buggy) VS 2015 warning, which this change disables for this source file. The VS 2015 warning bug is discussed by a VC++ compiler dev in one of the answers to this question: http://stackoverflow.com/questions/34013930/error-c4592-symbol-will-be-dynami... TBR=sebsg@chromium.org BUG=440500 ========== to ========== Disable VS 2015 warning about global constructor Having std::vector as a global variable means that constructors and destructors will run at startup and shutdown, which can be problematic. This also triggered a (buggy) VS 2015 warning, which this change disables for this source file. The VS 2015 warning bug is discussed by a VC++ compiler dev in one of the answers to this question: http://stackoverflow.com/questions/34013930/error-c4592-symbol-will-be-dynami... TBR=vabr@chromium.org BUG=440500 ==========
The CQ bit was checked by brucedawson@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1517103003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1517103003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was unchecked by brucedawson@chromium.org
Trying again with necessary #ifdefs. Trying to land tonight in an effort to get the VS 2015 builders running over the weekend. BTW, arguably better long-term fix is at crrev.com/1511333006/
The CQ bit was checked by brucedawson@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1517103003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1517103003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by brucedawson@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1517103003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1517103003/20001
Message was sent while issue was closed.
Description was changed from ========== Disable VS 2015 warning about global constructor Having std::vector as a global variable means that constructors and destructors will run at startup and shutdown, which can be problematic. This also triggered a (buggy) VS 2015 warning, which this change disables for this source file. The VS 2015 warning bug is discussed by a VC++ compiler dev in one of the answers to this question: http://stackoverflow.com/questions/34013930/error-c4592-symbol-will-be-dynami... TBR=vabr@chromium.org BUG=440500 ========== to ========== Disable VS 2015 warning about global constructor Having std::vector as a global variable means that constructors and destructors will run at startup and shutdown, which can be problematic. This also triggered a (buggy) VS 2015 warning, which this change disables for this source file. The VS 2015 warning bug is discussed by a VC++ compiler dev in one of the answers to this question: http://stackoverflow.com/questions/34013930/error-c4592-symbol-will-be-dynami... TBR=vabr@chromium.org BUG=440500 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Disable VS 2015 warning about global constructor Having std::vector as a global variable means that constructors and destructors will run at startup and shutdown, which can be problematic. This also triggered a (buggy) VS 2015 warning, which this change disables for this source file. The VS 2015 warning bug is discussed by a VC++ compiler dev in one of the answers to this question: http://stackoverflow.com/questions/34013930/error-c4592-symbol-will-be-dynami... TBR=vabr@chromium.org BUG=440500 ========== to ========== Disable VS 2015 warning about global constructor Having std::vector as a global variable means that constructors and destructors will run at startup and shutdown, which can be problematic. This also triggered a (buggy) VS 2015 warning, which this change disables for this source file. The VS 2015 warning bug is discussed by a VC++ compiler dev in one of the answers to this question: http://stackoverflow.com/questions/34013930/error-c4592-symbol-will-be-dynami... TBR=vabr@chromium.org BUG=440500 Committed: https://crrev.com/f7199714336c7fa05b465b9b5ba051999566b657 Cr-Commit-Position: refs/heads/master@{#364927} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/f7199714336c7fa05b465b9b5ba051999566b657 Cr-Commit-Position: refs/heads/master@{#364927}
Message was sent while issue was closed.
vabr@chromium.org changed reviewers: + vabr@chromium.org
Message was sent while issue was closed.
lgtm |
