Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1517073003: Fix^2 HasEnumerableElements (Closed)

Created:
5 years ago by Jakob Kummerow
Modified:
5 years ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix^2 HasEnumerableElements Arguments objects can have packed elements too. R=verwaest@chromium.org Committed: https://crrev.com/430bfd1b024636e9909d54712803c465bf10730d Cr-Commit-Position: refs/heads/master@{#32797}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/objects.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Jakob Kummerow
5 years ago (2015-12-11 09:43:46 UTC) #1
Toon Verwaest
lgtm, but could you add a test?
5 years ago (2015-12-11 10:06:28 UTC) #2
Jakob Kummerow
Can't add a test because other existing conditions make it impossible to reach this code ...
5 years ago (2015-12-11 11:51:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1517073003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1517073003/1
5 years ago (2015-12-11 11:52:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-11 14:08:16 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-11 14:09:16 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/430bfd1b024636e9909d54712803c465bf10730d
Cr-Commit-Position: refs/heads/master@{#32797}

Powered by Google App Engine
This is Rietveld 408576698