Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1517013003: Revert "dart2js: add support for configuration-specific imports." (Closed)

Created:
5 years ago by floitsch
Modified:
5 years ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "dart2js: add support for configuration-specific imports." This reverts commit 64edfaf21af3153f32e1229dd97c9b3d40cbfb2b. Committed: https://github.com/dart-lang/sdk/commit/f38b810d334900317ee6c919b45ebd0c673fdb02

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -407 lines) Patch
M pkg/compiler/lib/src/apiimpl.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/commandline_options.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 2 chunks +3 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/dart2js.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/library_loader.dart View 1 chunk +1 line, -15 lines 0 comments Download
M pkg/compiler/lib/src/parser/class_element_parser.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/parser/diet_parser_task.dart View 2 chunks +2 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/parser/element_listener.dart View 2 chunks +2 lines, -25 lines 0 comments Download
M pkg/compiler/lib/src/parser/listener.dart View 1 chunk +0 lines, -18 lines 0 comments Download
M pkg/compiler/lib/src/parser/parser.dart View 3 chunks +3 lines, -51 lines 0 comments Download
M pkg/compiler/lib/src/parser/parser_task.dart View 2 chunks +2 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/parser/partial_parser.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/patch_parser.dart View 4 chunks +4 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/tree/nodes.dart View 9 chunks +4 lines, -74 lines 0 comments Download
M pkg/compiler/lib/src/tree/unparser.dart View 2 chunks +0 lines, -28 lines 0 comments Download
M tests/compiler/dart2js/unparser_test.dart View 2 chunks +0 lines, -53 lines 0 comments Download
D tests/language/config_import_lib1a.dart View 1 chunk +0 lines, -5 lines 0 comments Download
D tests/language/config_import_lib1b.dart View 1 chunk +0 lines, -5 lines 0 comments Download
D tests/language/config_import_lib1c.dart View 1 chunk +0 lines, -5 lines 0 comments Download
D tests/language/config_import_lib2a.dart View 1 chunk +0 lines, -5 lines 0 comments Download
D tests/language/config_import_lib2b.dart View 1 chunk +0 lines, -5 lines 0 comments Download
D tests/language/config_import_lib2c.dart View 1 chunk +0 lines, -5 lines 0 comments Download
D tests/language/config_import_lib3a.dart View 1 chunk +0 lines, -5 lines 0 comments Download
D tests/language/config_import_lib3b.dart View 1 chunk +0 lines, -5 lines 0 comments Download
D tests/language/config_import_lib3c.dart View 1 chunk +0 lines, -5 lines 0 comments Download
D tests/language/config_import_lib4a.dart View 1 chunk +0 lines, -5 lines 0 comments Download
D tests/language/config_import_lib4b.dart View 1 chunk +0 lines, -5 lines 0 comments Download
D tests/language/config_import_lib4c.dart View 1 chunk +0 lines, -5 lines 0 comments Download
D tests/language/config_import_test.dart View 1 chunk +0 lines, -30 lines 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/language/language_analyzer.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
floitsch
Forgot to make update the status files for VM and analyzer. Will revert, fix, and ...
5 years ago (2015-12-10 23:49:24 UTC) #2
floitsch
TBR.
5 years ago (2015-12-10 23:49:33 UTC) #3
floitsch
Committed patchset #1 (id:1) manually as f38b810d334900317ee6c919b45ebd0c673fdb02 (presubmit successful).
5 years ago (2015-12-10 23:49:43 UTC) #5
Johnni Winther
5 years ago (2015-12-11 09:40:44 UTC) #6
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698