ui/views/controls/button/custom_button.cc - Issue 1517003002: Fixes stale hover or ink ripple visuals when dragging over extension buttons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/button/custom_button.cc

Issue 1517003002: Fixes stale hover or ink ripple visuals when dragging over extension buttons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes stale hover or ink ripple visuals when dragging over extension buttons (nits) Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/controls/button/custom_button.cc

diff --git a/ui/views/controls/button/custom_button.cc b/ui/views/controls/button/custom_button.cc

index 62fec14cbce91d26834649fe869231a99e9dbf97..5dab611315004990bc09fafb918353dc801460a4 100644

--- a/ui/views/controls/button/custom_button.cc

+++ b/ui/views/controls/button/custom_button.cc

@@ -186,6 +186,8 @@ void CustomButton::OnMouseCaptureLost() {

// Starting a drag results in a MouseCaptureLost, we need to ignore it.

if (state_ != STATE_DISABLED && !InDrag())

SetState(STATE_NORMAL);

+ if (ink_drop_delegate_)

+ ink_drop_delegate_->OnAction(views::InkDropState::HIDDEN);

}

void CustomButton::OnMouseEntered(const ui::MouseEvent& event) {

« no previous file with comments | « no previous file | ui/views/controls/button/custom_button_unittest.cc » ('j') | no next file with comments »