pkg/analysis_server/lib/src/services/completion/dart/library_member_contributor.dart - Issue 1516963002: simplify library element accessor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/library_member_contributor.dart

Issue 1516963002: simplify library element accessor (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: merge Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart ('k') | pkg/analysis_server/lib/src/services/completion/dart/named_constructor_contributor.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/dart/library_member_contributor.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/dart/library_member_contributor.dart b/pkg/analysis_server/lib/src/services/completion/dart/library_member_contributor.dart

index d0653c901ab8ec8e6be33ee1f65881d7cda414fe..7ecbc643a278b95a2be91760c5558cdbc5e81e2e 100644

--- a/pkg/analysis_server/lib/src/services/completion/dart/library_member_contributor.dart

+++ b/pkg/analysis_server/lib/src/services/completion/dart/library_member_contributor.dart

@@ -35,8 +35,8 @@ class LibraryMemberContributor extends DartCompletionContributor {

if (targetId is SimpleIdentifier && !request.target.isCascade) {

Element elem = targetId.bestElement;

if (elem is PrefixElement) {

- LibraryElement containingLibrary = await request.libraryElement;

List<Directive> directives = await request.resolveDirectives();

+ LibraryElement containingLibrary = request.libraryElement;

// Gracefully degrade if the library or directives

// could not be determined (e.g. detached part file or source change)

if (containingLibrary != null && directives != null) {