Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: pkg/analysis_server/lib/src/provisional/completion/dart/completion_dart.dart

Issue 1516963002: simplify library element accessor (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: merge Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/provisional/completion/dart/completion_dart.dart
diff --git a/pkg/analysis_server/lib/src/provisional/completion/dart/completion_dart.dart b/pkg/analysis_server/lib/src/provisional/completion/dart/completion_dart.dart
index 6163a5415cb98ec9c660a03e511f4206e9447959..b651ddb7e22f36cf81c3439c5e2d517e8ed117aa 100644
--- a/pkg/analysis_server/lib/src/provisional/completion/dart/completion_dart.dart
+++ b/pkg/analysis_server/lib/src/provisional/completion/dart/completion_dart.dart
@@ -68,14 +68,11 @@ abstract class DartCompletionRequest extends CompletionRequest {
Expression get dotTarget;
/**
- * Return a [Future] that completes with the library element
- * which contains the unit in which the completion is occurring.
- * The [Future] may return `null` if the library cannot be determined
+ * Return the library element which contains the unit in which the completion
+ * is occurring. This may return `null` if the library cannot be determined
* (e.g. unlinked part file).
- * Any information obtained from [target] prior to calling this method
- * should be discarded as it may have changed.
*/
- Future<LibraryElement> get libraryElement;
+ LibraryElement get libraryElement;
/**
* The source for the library containing the completion request.
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698