Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 151693004: Clean-up: Replaces obsolete Font/FontList methods. (Closed)

Created:
6 years, 10 months ago by Yuki
Modified:
6 years, 10 months ago
Reviewers:
xiyuan, tapted
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Visibility:
Public.

Description

Clean-up: Replaces obsolete Font/FontList methods. Replaces obsolete methods of gfx::Font and gfx::FontList with new ones. BUG=265485 TEST=Run app_list_unittests. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248915

Patch Set 1 #

Patch Set 2 : Synced. #

Patch Set 3 : Synced. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M ui/app_list/cocoa/apps_grid_view_item.mm View 2 chunks +4 lines, -3 lines 0 comments Download
M ui/app_list/cocoa/signin_view_controller.mm View 2 chunks +5 lines, -3 lines 0 comments Download
M ui/app_list/views/signin_view.cc View 1 chunk +6 lines, -9 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
Yuki
Could you review this CL?
6 years, 10 months ago (2014-02-03 13:12:50 UTC) #1
xiyuan
tapted@ is a better reviewer for this CL.
6 years, 10 months ago (2014-02-03 17:18:33 UTC) #2
tapted
lgtm with a description nit: these will have test coverage in the app_list_unittests target (but ...
6 years, 10 months ago (2014-02-04 00:48:52 UTC) #3
Yuki
The CQ bit was checked by yukishiino@chromium.org
6 years, 10 months ago (2014-02-04 03:06:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/151693004/1
6 years, 10 months ago (2014-02-04 03:06:23 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 04:01:37 UTC) #6
commit-bot: I haz the power
Retried try job too often on win for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=145877
6 years, 10 months ago (2014-02-04 04:01:37 UTC) #7
Yuki
The CQ bit was checked by yukishiino@chromium.org
6 years, 10 months ago (2014-02-04 04:56:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/151693004/1
6 years, 10 months ago (2014-02-04 04:56:43 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 05:08:40 UTC) #10
commit-bot: I haz the power
Retried try job too often on win for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=145926
6 years, 10 months ago (2014-02-04 05:08:40 UTC) #11
Yuki
The CQ bit was checked by yukishiino@chromium.org
6 years, 10 months ago (2014-02-04 05:44:06 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/151693004/440001
6 years, 10 months ago (2014-02-04 05:45:15 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 06:27:48 UTC) #14
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=222843
6 years, 10 months ago (2014-02-04 06:27:48 UTC) #15
Yuki
The CQ bit was checked by yukishiino@chromium.org
6 years, 10 months ago (2014-02-04 07:26:02 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/151693004/440001
6 years, 10 months ago (2014-02-04 07:26:43 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 08:33:06 UTC) #18
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) url_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=120580
6 years, 10 months ago (2014-02-04 08:33:07 UTC) #19
Yuki
The CQ bit was checked by yukishiino@chromium.org
6 years, 10 months ago (2014-02-05 05:04:14 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/151693004/870001
6 years, 10 months ago (2014-02-05 05:05:42 UTC) #21
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 08:14:53 UTC) #22
Message was sent while issue was closed. 
Change committed as 248915

Powered by Google App Engine
This is Rietveld 408576698