Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1516883002: do not suggest completions for cascade on library prefix - fixes #25215 (Closed)

Created:
5 years ago by danrubel
Modified:
5 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

do not suggest completions for cascade on library prefix - fixes #25215 add CompletionRequest dotTarget add CompletionTarget offset and isCascade R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/37d52a5d1c2771d20fc46b19c30f16a81492edcc

Patch Set 1 #

Patch Set 2 : suggest members for prefixed class identifier #

Patch Set 3 : merge #

Messages

Total messages: 5 (2 generated)
danrubel
5 years ago (2015-12-10 16:38:45 UTC) #2
scheglov
LGTM
5 years ago (2015-12-10 16:42:34 UTC) #3
danrubel
5 years ago (2015-12-10 16:57:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
37d52a5d1c2771d20fc46b19c30f16a81492edcc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698