Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1516863007: In BUILD.public, enable SK_SUPPORT_LEGACY_HAIR_IGNORES_CAPS. (Closed)

Created:
5 years ago by dogben
Modified:
5 years ago
Reviewers:
mtklein
CC:
caryclark, reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

In BUILD.public, enable SK_SUPPORT_LEGACY_HAIR_IGNORES_CAPS. Somehow https://codereview.chromium.org/1491843006 causes fills to change in one test. BUG=skia: Committed: https://skia.googlesource.com/skia/+/b6c77f6d62a62db3aec483e0a995ca30b9c97f0b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M BUILD.public View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
dogben
The failing test passes with SK_SUPPORT_LEGACY_HAIR_IGNORES_CAPS. I am running a full presubmit now.
5 years ago (2015-12-11 15:23:50 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1516863007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1516863007/1
5 years ago (2015-12-11 15:30:23 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-11 15:43:24 UTC) #6
mtklein
lgtm
5 years ago (2015-12-11 15:51:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1516863007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1516863007/1
5 years ago (2015-12-11 15:53:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/b6c77f6d62a62db3aec483e0a995ca30b9c97f0b
5 years ago (2015-12-11 15:54:27 UTC) #11
dogben
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1530533003/ by benjaminwagner@google.com. ...
5 years ago (2015-12-15 15:13:02 UTC) #12
mtklein
5 years ago (2015-12-15 15:13:44 UTC) #13
Message was sent while issue was closed.
On 2015/12/15 at 15:13:02, benjaminwagner wrote:
> A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1530533003/ by benjaminwagner@google.com.
> 
> The reason for reverting is: The failing test has been blacklisted. The issue
was not caused by this CL..

Oh that's wonderful!

Powered by Google App Engine
This is Rietveld 408576698