Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: src/DartARM32/assembler_arm.cc

Issue 1516863003: Add various forms of LDREX/STREX to ARM integrated assembler. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Update Dart files and fix nits. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/DartARM32/assembler_arm.cc
diff --git a/src/DartARM32/assembler_arm.cc b/src/DartARM32/assembler_arm.cc
index 1c1943973947f08dd38e5804ba9dfdb48b2c239f..acbdc7166ef7f776daec4b189daa12b998417e21 100644
--- a/src/DartARM32/assembler_arm.cc
+++ b/src/DartARM32/assembler_arm.cc
@@ -557,9 +557,8 @@ void Assembler::stm(BlockAddressMode am, Register base, RegList regs,
ASSERT(regs != 0);
EmitMultiMemOp(cond, am, false, base, regs);
}
-#endif
-
+// Moved to ARM::AssemblerARM32::ldrex();
void Assembler::ldrex(Register rt, Register rn, Condition cond) {
ASSERT(TargetCPUFeatures::arm_version() != ARMv5TE);
ASSERT(rn != kNoRegister);
@@ -575,7 +574,7 @@ void Assembler::ldrex(Register rt, Register rn, Condition cond) {
Emit(encoding);
}
-
+// Moved to ARM::AssemblerARM32::strex();
void Assembler::strex(Register rd, Register rt, Register rn, Condition cond) {
ASSERT(TargetCPUFeatures::arm_version() != ARMv5TE);
ASSERT(rn != kNoRegister);
@@ -591,7 +590,7 @@ void Assembler::strex(Register rd, Register rt, Register rn, Condition cond) {
(static_cast<int32_t>(rt) << kStrExRtShift);
Emit(encoding);
}
-
+#endif
void Assembler::clrex() {
ASSERT(TargetCPUFeatures::arm_version() != ARMv5TE);

Powered by Google App Engine
This is Rietveld 408576698