[proxy] fixing harmony/proxy.js tests and improving error messages + some drive-by fixes

test/mjsunit/es6/regress/regress-cr493566.js

Index: test/mjsunit/es6/regress/regress-cr493566.js
diff --git a/test/mjsunit/es6/regress/regress-cr493566.js b/test/mjsunit/es6/regress/regress-cr493566.js
index 95a5a3edd09eb061bbfcfaabf648fc9adb6e73f8..19b2eb695da1c1ae14a559081097e9bb133c00d4 100644
--- a/test/mjsunit/es6/regress/regress-cr493566.js
+++ b/test/mjsunit/es6/regress/regress-cr493566.js
@@ -2,34 +2,41 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --harmony-proxies
+// Flags: --harmony-proxies --harmony-reflect
 
 "use strict";
-
-
 var global = this;
 
-
 (function TestGlobalReceiver() {
   class A {
-    s() {
-      super.bla = 10;
+    s(value) {
+      super.bla = value;
     }
   }
-  new A().s.call(global);
+  var a = new A();
+  a.s(9);
+  assertEquals(undefined, global.bla);
+  assertEquals(9, a.bla);
+
+  a = new A();
+  a.s.call(global, 10);
   assertEquals(10, global.bla);
+  assertEquals(undefined, a.bla);
 })();
 
 
 (function TestProxyProto() {
   var calls = 0;
   var handler = {
-    getPropertyDescriptor: function(name) {
+    set(t, p, v, r) {
       calls++;
+      return Reflect.set(t, p, v, r);
+    },
+    getPropertyDescriptor(target, name) {
+      calls += 10;
       return undefined;
     }
   };
-
   var target = {};
   var proxy = new Proxy(target, handler);
   var object = {
@@ -43,10 +50,18 @@ var global = this;
   };
 
   object.setX(1);
+  assertEquals(1, object.x);
+  assertEquals(1, Object.getOwnPropertyDescriptor(object, 'x').value);
+  assertEquals(1, calls);
+
+  calls = 0;
+  object.setX.call(proxy, 2);
+  assertEquals(2, target.x);
   assertEquals(1, Object.getOwnPropertyDescriptor(object, 'x').value);
   assertEquals(1, calls);
 
   var sym = Symbol();
+  calls = 0;
   object.setSymbol.call(global, sym, 2);
   assertEquals(2, Object.getOwnPropertyDescriptor(global, sym).value);
   // We currently do not invoke proxy traps for symbols
@@ -62,19 +77,27 @@ var global = this;
   };
 
   var calls = 0;
+  var target = {target:1};
   var handler = {
-    getPropertyDescriptor(name) {
-      assertUnreachable();
+    getOwnPropertyDescriptor(t, name) {
+      calls++;
+    },
+    defineOwnProperty(t, name) {
+      calls += 10;
     },
     set(receiver, name, value) {
-      calls++;
-      assertEquals(proxy, receiver);
-      assertEquals('y', name);
-      assertEquals(3, value);
+      calls += 100;
+      return true;
     }
   };
+  var proxy = new Proxy(target, handler);
+
+  assertEquals(undefined, object.y);
+  object.setY(10);
+  assertEquals(10, object.y);
 
-  var proxy = new Proxy({}, handler);
+  // Change the receiver to the proxy, but the set is called on the global.
   object.setY.call(proxy, 3);
+  assertEquals(3, target.y);

[Camillo Bruni, 2015/12/10 20:22:14]

this doesn't make any sense to me, especially since I have a [[Set]] trap in the
proxy which is never called.

   assertEquals(1, calls);
 })();