src/full-codegen/ia32/full-codegen-ia32.cc - Issue 1516843002: [proxy] fixing harmony/proxy.js tests and improving error messages + some drive-by fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/ia32/full-codegen-ia32.cc

Issue 1516843002: [proxy] fixing harmony/proxy.js tests and improving error messages + some drive-by fixes (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: enabling and fixing more tests Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « src/full-codegen/arm64/full-codegen-arm64.cc ('k') | src/full-codegen/mips/full-codegen-mips.cc » ('j') | test/mjsunit/es6/regress/regress-cr493566.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/full-codegen/ia32/full-codegen-ia32.cc

diff --git a/src/full-codegen/ia32/full-codegen-ia32.cc b/src/full-codegen/ia32/full-codegen-ia32.cc

index 28fbe85bbe6d53b6e7b79380bbf9139b3d2aca2f..0af5ba308d924768b62c39fd865ac73912b0c764 100644

--- a/src/full-codegen/ia32/full-codegen-ia32.cc

+++ b/src/full-codegen/ia32/full-codegen-ia32.cc

@@ -1071,12 +1071,6 @@ void FullCodeGenerator::VisitForInStatement(ForInStatement* stmt) {

__ cmp(edx, FieldOperand(ecx, HeapObject::kMapOffset));

__ j(equal, &update_each, Label::kNear);

- // For proxies, no filtering is done.

- // TODO(rossberg): What if only a prototype is a proxy? Not specified yet.

- DCHECK(Smi::FromInt(0) == 0);

- __ test(edx, edx);

- __ j(zero, &update_each);

// Convert the entry to a string or null if it isn't a property

// anymore. If the property has been removed while iterating, we

// just skip it.

« no previous file with comments | « src/full-codegen/arm64/full-codegen-arm64.cc ('k') | src/full-codegen/mips/full-codegen-mips.cc » ('j') | test/mjsunit/es6/regress/regress-cr493566.js » ('J')