Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: src/full-codegen/ppc/full-codegen-ppc.cc

Issue 1516843002: [proxy] fixing harmony/proxy.js tests and improving error messages + some drive-by fixes (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: WIP fix protoype walks with access checks Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/full-codegen/ppc/full-codegen-ppc.cc
diff --git a/src/full-codegen/ppc/full-codegen-ppc.cc b/src/full-codegen/ppc/full-codegen-ppc.cc
index c7718a893a0aa091bc05d8c59900e6843c52e3e5..82ddc93442c6b7d03e9e540fa462c1f7c4ac4731 100644
--- a/src/full-codegen/ppc/full-codegen-ppc.cc
+++ b/src/full-codegen/ppc/full-codegen-ppc.cc
@@ -1058,7 +1058,6 @@ void FullCodeGenerator::VisitForInStatement(ForInStatement* stmt) {
__ b(&exit);
// We got a fixed array in register r3. Iterate through that.
- Label non_proxy;
__ bind(&fixed_array);
__ EmitLoadTypeFeedbackVector(r4);
@@ -1066,14 +1065,7 @@ void FullCodeGenerator::VisitForInStatement(ForInStatement* stmt) {
int vector_index = SmiFromSlot(slot)->value();
__ StoreP(
r5, FieldMemOperand(r4, FixedArray::OffsetOfElementAt(vector_index)), r0);
-
- __ LoadSmiLiteral(r4, Smi::FromInt(1)); // Smi indicates slow check
- __ LoadP(r5, MemOperand(sp, 0 * kPointerSize)); // Get enumerated object
- STATIC_ASSERT(JS_PROXY_TYPE == FIRST_JS_RECEIVER_TYPE);
- __ CompareObjectType(r5, r6, r6, JS_PROXY_TYPE);
- __ bgt(&non_proxy);
- __ LoadSmiLiteral(r4, Smi::FromInt(0)); // Zero indicates proxy
- __ bind(&non_proxy);
+ __ LoadSmiLiteral(r4, Smi::FromInt(1)); // Smi(1) indicates slow check
__ Push(r4, r3); // Smi and array
__ LoadP(r4, FieldMemOperand(r3, FixedArray::kLengthOffset));
__ LoadSmiLiteral(r3, Smi::FromInt(0));
@@ -1107,11 +1099,6 @@ void FullCodeGenerator::VisitForInStatement(ForInStatement* stmt) {
__ cmp(r7, r5);
__ beq(&update_each);
- // For proxies, no filtering is done.
- // TODO(rossberg): What if only a prototype is a proxy? Not specified yet.
- __ CmpSmiLiteral(r5, Smi::FromInt(0), r0);
- __ beq(&update_each);
-
// Convert the entry to a string or (smi) 0 if it isn't a property
// any more. If the property has been removed while iterating, we
// just skip it.

Powered by Google App Engine
This is Rietveld 408576698