Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1783)

Unified Diff: test/mjsunit/es6/regress/regress-cr493566.js

Issue 1516843002: [proxy] fixing harmony/proxy.js tests and improving error messages + some drive-by fixes (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/mjsunit/es6/regress/regress-cr493566.js
diff --git a/test/mjsunit/es6/regress/regress-cr493566.js b/test/mjsunit/es6/regress/regress-cr493566.js
index 95a5a3edd09eb061bbfcfaabf648fc9adb6e73f8..28a9fa0601704918ff4d6abbaa34c54ffded3d4a 100644
--- a/test/mjsunit/es6/regress/regress-cr493566.js
+++ b/test/mjsunit/es6/regress/regress-cr493566.js
@@ -9,51 +9,6 @@
var global = this;
-
-(function TestGlobalReceiver() {
- class A {
- s() {
- super.bla = 10;
- }
- }
- new A().s.call(global);
- assertEquals(10, global.bla);
-})();
-
-
-(function TestProxyProto() {
- var calls = 0;
- var handler = {
- getPropertyDescriptor: function(name) {
- calls++;
- return undefined;
- }
- };
-
- var target = {};
- var proxy = new Proxy(target, handler);
- var object = {
- __proto__: proxy,
- setX(v) {
- super.x = v;
- },
- setSymbol(sym, v) {
- super[sym] = v;
- }
- };
-
- object.setX(1);
- assertEquals(1, Object.getOwnPropertyDescriptor(object, 'x').value);
- assertEquals(1, calls);
-
- var sym = Symbol();
- object.setSymbol.call(global, sym, 2);
- assertEquals(2, Object.getOwnPropertyDescriptor(global, sym).value);
- // We currently do not invoke proxy traps for symbols
- assertEquals(1, calls);
-})();
-
neis 2015/12/10 15:13:49 Not sure why I just deleted this. Could you try t
-
(function TestProxyReceiver() {
var object = {
setY(v) {
@@ -63,7 +18,7 @@ var global = this;
var calls = 0;
var handler = {
- getPropertyDescriptor(name) {
+ getOwnPropertyDescriptor() {
assertUnreachable();
},
set(receiver, name, value) {

Powered by Google App Engine
This is Rietveld 408576698