Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Side by Side Diff: src/full-codegen/x64/full-codegen-x64.cc

Issue 1516843002: [proxy] fixing harmony/proxy.js tests and improving error messages + some drive-by fixes (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: enabling and fixing more tests Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X64 5 #if V8_TARGET_ARCH_X64
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 1078 matching lines...) Expand 10 before | Expand all | Expand 10 after
1089 // permanent slow case into register rdx. 1089 // permanent slow case into register rdx.
1090 __ movp(rdx, Operand(rsp, 3 * kPointerSize)); 1090 __ movp(rdx, Operand(rsp, 3 * kPointerSize));
1091 1091
1092 // Check if the expected map still matches that of the enumerable. 1092 // Check if the expected map still matches that of the enumerable.
1093 // If not, we may have to filter the key. 1093 // If not, we may have to filter the key.
1094 Label update_each; 1094 Label update_each;
1095 __ movp(rcx, Operand(rsp, 4 * kPointerSize)); 1095 __ movp(rcx, Operand(rsp, 4 * kPointerSize));
1096 __ cmpp(rdx, FieldOperand(rcx, HeapObject::kMapOffset)); 1096 __ cmpp(rdx, FieldOperand(rcx, HeapObject::kMapOffset));
1097 __ j(equal, &update_each, Label::kNear); 1097 __ j(equal, &update_each, Label::kNear);
1098 1098
1099 // For proxies, no filtering is done.
1100 // TODO(rossberg): What if only a prototype is a proxy? Not specified yet.
1101 __ Cmp(rdx, Smi::FromInt(0));
1102 __ j(equal, &update_each, Label::kNear);
1103
1104 // Convert the entry to a string or null if it isn't a property 1099 // Convert the entry to a string or null if it isn't a property
1105 // anymore. If the property has been removed while iterating, we 1100 // anymore. If the property has been removed while iterating, we
1106 // just skip it. 1101 // just skip it.
1107 __ Push(rcx); // Enumerable. 1102 __ Push(rcx); // Enumerable.
1108 __ Push(rbx); // Current entry. 1103 __ Push(rbx); // Current entry.
1109 __ CallRuntime(Runtime::kForInFilter, 2); 1104 __ CallRuntime(Runtime::kForInFilter, 2);
1110 PrepareForBailoutForId(stmt->FilterId(), TOS_REG); 1105 PrepareForBailoutForId(stmt->FilterId(), TOS_REG);
1111 __ CompareRoot(rax, Heap::kUndefinedValueRootIndex); 1106 __ CompareRoot(rax, Heap::kUndefinedValueRootIndex);
1112 __ j(equal, loop_statement.continue_label()); 1107 __ j(equal, loop_statement.continue_label());
1113 __ movp(rbx, rax); 1108 __ movp(rbx, rax);
(...skipping 3717 matching lines...) Expand 10 before | Expand all | Expand 10 after
4831 Assembler::target_address_at(call_target_address, 4826 Assembler::target_address_at(call_target_address,
4832 unoptimized_code)); 4827 unoptimized_code));
4833 return OSR_AFTER_STACK_CHECK; 4828 return OSR_AFTER_STACK_CHECK;
4834 } 4829 }
4835 4830
4836 4831
4837 } // namespace internal 4832 } // namespace internal
4838 } // namespace v8 4833 } // namespace v8
4839 4834
4840 #endif // V8_TARGET_ARCH_X64 4835 #endif // V8_TARGET_ARCH_X64
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698