Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Side by Side Diff: src/full-codegen/ppc/full-codegen-ppc.cc

Issue 1516843002: [proxy] fixing harmony/proxy.js tests and improving error messages + some drive-by fixes (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: enabling and fixing more tests Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_PPC 5 #if V8_TARGET_ARCH_PPC
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 1089 matching lines...) Expand 10 before | Expand all | Expand 10 after
1100 __ LoadP(r5, MemOperand(sp, 3 * kPointerSize)); 1100 __ LoadP(r5, MemOperand(sp, 3 * kPointerSize));
1101 1101
1102 // Check if the expected map still matches that of the enumerable. 1102 // Check if the expected map still matches that of the enumerable.
1103 // If not, we may have to filter the key. 1103 // If not, we may have to filter the key.
1104 Label update_each; 1104 Label update_each;
1105 __ LoadP(r4, MemOperand(sp, 4 * kPointerSize)); 1105 __ LoadP(r4, MemOperand(sp, 4 * kPointerSize));
1106 __ LoadP(r7, FieldMemOperand(r4, HeapObject::kMapOffset)); 1106 __ LoadP(r7, FieldMemOperand(r4, HeapObject::kMapOffset));
1107 __ cmp(r7, r5); 1107 __ cmp(r7, r5);
1108 __ beq(&update_each); 1108 __ beq(&update_each);
1109 1109
1110 // For proxies, no filtering is done.
1111 // TODO(rossberg): What if only a prototype is a proxy? Not specified yet.
1112 __ CmpSmiLiteral(r5, Smi::FromInt(0), r0);
1113 __ beq(&update_each);
1114
1115 // Convert the entry to a string or (smi) 0 if it isn't a property 1110 // Convert the entry to a string or (smi) 0 if it isn't a property
1116 // any more. If the property has been removed while iterating, we 1111 // any more. If the property has been removed while iterating, we
1117 // just skip it. 1112 // just skip it.
1118 __ Push(r4, r6); // Enumerable and current entry. 1113 __ Push(r4, r6); // Enumerable and current entry.
1119 __ CallRuntime(Runtime::kForInFilter, 2); 1114 __ CallRuntime(Runtime::kForInFilter, 2);
1120 PrepareForBailoutForId(stmt->FilterId(), TOS_REG); 1115 PrepareForBailoutForId(stmt->FilterId(), TOS_REG);
1121 __ mr(r6, r3); 1116 __ mr(r6, r3);
1122 __ LoadRoot(r0, Heap::kUndefinedValueRootIndex); 1117 __ LoadRoot(r0, Heap::kUndefinedValueRootIndex);
1123 __ cmp(r3, r0); 1118 __ cmp(r3, r0);
1124 __ beq(loop_statement.continue_label()); 1119 __ beq(loop_statement.continue_label());
(...skipping 3774 matching lines...) Expand 10 before | Expand all | Expand 10 after
4899 return ON_STACK_REPLACEMENT; 4894 return ON_STACK_REPLACEMENT;
4900 } 4895 }
4901 4896
4902 DCHECK(interrupt_address == 4897 DCHECK(interrupt_address ==
4903 isolate->builtins()->OsrAfterStackCheck()->entry()); 4898 isolate->builtins()->OsrAfterStackCheck()->entry());
4904 return OSR_AFTER_STACK_CHECK; 4899 return OSR_AFTER_STACK_CHECK;
4905 } 4900 }
4906 } // namespace internal 4901 } // namespace internal
4907 } // namespace v8 4902 } // namespace v8
4908 #endif // V8_TARGET_ARCH_PPC 4903 #endif // V8_TARGET_ARCH_PPC
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698