Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Side by Side Diff: src/full-codegen/mips64/full-codegen-mips64.cc

Issue 1516843002: [proxy] fixing harmony/proxy.js tests and improving error messages + some drive-by fixes (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: enabling and fixing more tests Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS64 5 #if V8_TARGET_ARCH_MIPS64
6 6
7 // Note on Mips implementation: 7 // Note on Mips implementation:
8 // 8 //
9 // The result_register() for mips is the 'v0' register, which is defined 9 // The result_register() for mips is the 'v0' register, which is defined
10 // by the ABI to contain function return values. However, the first 10 // by the ABI to contain function return values. However, the first
(...skipping 1120 matching lines...) Expand 10 before | Expand all | Expand 10 after
1131 // permanent slow case into register a2. 1131 // permanent slow case into register a2.
1132 __ ld(a2, MemOperand(sp, 3 * kPointerSize)); 1132 __ ld(a2, MemOperand(sp, 3 * kPointerSize));
1133 1133
1134 // Check if the expected map still matches that of the enumerable. 1134 // Check if the expected map still matches that of the enumerable.
1135 // If not, we may have to filter the key. 1135 // If not, we may have to filter the key.
1136 Label update_each; 1136 Label update_each;
1137 __ ld(a1, MemOperand(sp, 4 * kPointerSize)); 1137 __ ld(a1, MemOperand(sp, 4 * kPointerSize));
1138 __ ld(a4, FieldMemOperand(a1, HeapObject::kMapOffset)); 1138 __ ld(a4, FieldMemOperand(a1, HeapObject::kMapOffset));
1139 __ Branch(&update_each, eq, a4, Operand(a2)); 1139 __ Branch(&update_each, eq, a4, Operand(a2));
1140 1140
1141 // For proxies, no filtering is done.
1142 // TODO(rossberg): What if only a prototype is a proxy? Not specified yet.
1143 DCHECK_EQ(static_cast<Smi*>(0), Smi::FromInt(0));
1144 __ Branch(&update_each, eq, a2, Operand(zero_reg));
1145
1146 // Convert the entry to a string or (smi) 0 if it isn't a property 1141 // Convert the entry to a string or (smi) 0 if it isn't a property
1147 // any more. If the property has been removed while iterating, we 1142 // any more. If the property has been removed while iterating, we
1148 // just skip it. 1143 // just skip it.
1149 __ Push(a1, a3); // Enumerable and current entry. 1144 __ Push(a1, a3); // Enumerable and current entry.
1150 __ CallRuntime(Runtime::kForInFilter, 2); 1145 __ CallRuntime(Runtime::kForInFilter, 2);
1151 PrepareForBailoutForId(stmt->FilterId(), TOS_REG); 1146 PrepareForBailoutForId(stmt->FilterId(), TOS_REG);
1152 __ mov(a3, result_register()); 1147 __ mov(a3, result_register());
1153 __ LoadRoot(at, Heap::kUndefinedValueRootIndex); 1148 __ LoadRoot(at, Heap::kUndefinedValueRootIndex);
1154 __ Branch(loop_statement.continue_label(), eq, a3, Operand(at)); 1149 __ Branch(loop_statement.continue_label(), eq, a3, Operand(at));
1155 1150
(...skipping 3771 matching lines...) Expand 10 before | Expand all | Expand 10 after
4927 reinterpret_cast<uint64_t>( 4922 reinterpret_cast<uint64_t>(
4928 isolate->builtins()->OsrAfterStackCheck()->entry())); 4923 isolate->builtins()->OsrAfterStackCheck()->entry()));
4929 return OSR_AFTER_STACK_CHECK; 4924 return OSR_AFTER_STACK_CHECK;
4930 } 4925 }
4931 4926
4932 4927
4933 } // namespace internal 4928 } // namespace internal
4934 } // namespace v8 4929 } // namespace v8
4935 4930
4936 #endif // V8_TARGET_ARCH_MIPS64 4931 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698