Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: src/full-codegen/arm/full-codegen-arm.cc

Issue 1516843002: [proxy] fixing harmony/proxy.js tests and improving error messages + some drive-by fixes (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: enabling and fixing more tests Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 1128 matching lines...) Expand 10 before | Expand all | Expand 10 after
1139 __ ldr(r2, MemOperand(sp, 3 * kPointerSize)); 1139 __ ldr(r2, MemOperand(sp, 3 * kPointerSize));
1140 1140
1141 // Check if the expected map still matches that of the enumerable. 1141 // Check if the expected map still matches that of the enumerable.
1142 // If not, we may have to filter the key. 1142 // If not, we may have to filter the key.
1143 Label update_each; 1143 Label update_each;
1144 __ ldr(r1, MemOperand(sp, 4 * kPointerSize)); 1144 __ ldr(r1, MemOperand(sp, 4 * kPointerSize));
1145 __ ldr(r4, FieldMemOperand(r1, HeapObject::kMapOffset)); 1145 __ ldr(r4, FieldMemOperand(r1, HeapObject::kMapOffset));
1146 __ cmp(r4, Operand(r2)); 1146 __ cmp(r4, Operand(r2));
1147 __ b(eq, &update_each); 1147 __ b(eq, &update_each);
1148 1148
1149 // For proxies, no filtering is done.
1150 // TODO(rossberg): What if only a prototype is a proxy? Not specified yet.
1151 __ cmp(r2, Operand(Smi::FromInt(0)));
1152 __ b(eq, &update_each);
1153
1154 // Convert the entry to a string or (smi) 0 if it isn't a property 1149 // Convert the entry to a string or (smi) 0 if it isn't a property
1155 // any more. If the property has been removed while iterating, we 1150 // any more. If the property has been removed while iterating, we
1156 // just skip it. 1151 // just skip it.
1157 __ push(r1); // Enumerable. 1152 __ push(r1); // Enumerable.
1158 __ push(r3); // Current entry. 1153 __ push(r3); // Current entry.
1159 __ CallRuntime(Runtime::kForInFilter, 2); 1154 __ CallRuntime(Runtime::kForInFilter, 2);
1160 PrepareForBailoutForId(stmt->FilterId(), TOS_REG); 1155 PrepareForBailoutForId(stmt->FilterId(), TOS_REG);
1161 __ mov(r3, Operand(r0)); 1156 __ mov(r3, Operand(r0));
1162 __ LoadRoot(ip, Heap::kUndefinedValueRootIndex); 1157 __ LoadRoot(ip, Heap::kUndefinedValueRootIndex);
1163 __ cmp(r0, ip); 1158 __ cmp(r0, ip);
(...skipping 3797 matching lines...) Expand 10 before | Expand all | Expand 10 after
4961 DCHECK(interrupt_address == 4956 DCHECK(interrupt_address ==
4962 isolate->builtins()->OsrAfterStackCheck()->entry()); 4957 isolate->builtins()->OsrAfterStackCheck()->entry());
4963 return OSR_AFTER_STACK_CHECK; 4958 return OSR_AFTER_STACK_CHECK;
4964 } 4959 }
4965 4960
4966 4961
4967 } // namespace internal 4962 } // namespace internal
4968 } // namespace v8 4963 } // namespace v8
4969 4964
4970 #endif // V8_TARGET_ARCH_ARM 4965 #endif // V8_TARGET_ARCH_ARM
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698