src/codec/SkWebpCodec.cpp - Issue 1516833003: Switch SkAutoMalloc to SkAutoTMalloc to avoid cast

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/codec/SkWebpCodec.cpp

Issue 1516833003: Switch SkAutoMalloc to SkAutoTMalloc to avoid cast (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Go back to patch set 3 Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/codec/SkWebpCodec.cpp

diff --git a/src/codec/SkWebpCodec.cpp b/src/codec/SkWebpCodec.cpp

index 2137877f1e7f2986144f2694ed02537993b3f297..6cfb3852948837b16d5e3f9f415b8e86d3e5e3df 100644

--- a/src/codec/SkWebpCodec.cpp

+++ b/src/codec/SkWebpCodec.cpp

@@ -230,8 +230,8 @@ SkCodec::Result SkWebpCodec::onGetPixels(const SkImageInfo& dstInfo, void* dst,

return kInvalidInput;

}

- SkAutoMalloc storage(BUFFER_SIZE);

- uint8_t* buffer = static_cast<uint8_t*>(storage.get());

+ SkAutoTMalloc<uint8_t> storage(BUFFER_SIZE);

+ uint8_t* buffer = storage.get();

while (true) {

const size_t bytesRead = stream()->read(buffer, BUFFER_SIZE);

if (0 == bytesRead) {

« no previous file with comments | « src/codec/SkSampledCodec.cpp ('k') | src/core/SkBitmap.cpp » ('j') | no next file with comments »