Switch SkAutoMalloc to SkAutoTMalloc to avoid cast

tests/Writer32Test.cpp

 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkRandom.h"
 #include "SkReader32.h"
 #include "SkWriter32.h"
@@ skipping 126 matching lines @@
         size_t alignedSize = SkAlign4(len + 1);
         for (size_t j = len; j < alignedSize; j++) {
             REPORTER_ASSERT(reporter, 0 == str[j]);
         }
     }
     REPORTER_ASSERT(reporter, reader.eof());
 }
 
 static void testWritePad(skiatest::Reporter* reporter, SkWriter32* writer) {
     // Create some random data to write.
-    const size_t dataSize = 10<<2;
-    SkASSERT(SkIsAlign4(dataSize));
+    const size_t dataSize = 10;
 
-    SkAutoMalloc originalData(dataSize);
+    SkAutoTMalloc<uint32_t> originalData(dataSize);
     {
         SkRandom rand(0);
-        uint32_t* ptr = static_cast<uint32_t*>(originalData.get());
-        uint32_t* stop = ptr + (dataSize>>2);
-        while (ptr < stop) {
-            *ptr++ = rand.nextU();
+        uint32_t* const ptr = originalData.get();

[mtklein, 2015/12/10 16:00:03]

It's fairly rare that we make const pointers.  This does seem fine, but an odd
CL to add it in?

[scroggo, 2015/12/10 16:26:45]

Oh, right; I meant to just use SkAutoTMalloc::operator[], but then forgot. D'oh.
Updated in next patch set.

+        for (size_t i = 0; i < dataSize; i++) {
+            ptr[i] = rand.nextU();
         }
 
         // Write  the random data to the writer at different lengths for
         // different alignments.
         for (size_t len = 0; len < dataSize; len++) {
             writer->writePad(originalData.get(), len);
         }
     }
 
     size_t totalBytes = writer->bytesWritten();
@@ skipping 107 matching lines @@
     testOverwriteT(reporter, &writer);
 }
 
 DEF_TEST(Writer32_misc, reporter) {
     test_reserve(reporter);
     test_string_null(reporter);
     test_ptr(reporter);
     test_rewind(reporter);
 }