Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 1516813003: Revert of Reland "Added an extra sync token field for extra command buffer..." (Closed)

Created:
5 years ago by johnme
Modified:
5 years ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, qsr+mojo_chromium.org, rjkroege, sievers+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland "Added an extra sync token field for extra command buffer..." (patchset #4 id:60001 of https://codereview.chromium.org/1499813003/ ) Reason for revert: Experimental revert - this might be the reason why all gl_tests are failing on Jelly Bean Tester? See https://crbug.com/568628. Original issue's description: > Reland "Added an extra sync token field for extra command buffer..." > > This reverts commit 5097a2103f86741a7d0e6567e57759be939182b0. > > R=dalecurtis@chromium.org, dcheng@chromium.org, piman@chromium.org, sky@chromium.org > BUG=514815, 566291 > > Committed: https://crrev.com/1ed246478fcfa39bcf1f617ae35cfc4fdf5bad8b > Cr-Commit-Position: refs/heads/master@{#363922} TBR=dcheng@chromium.org,dalecurtis@chromium.org,piman@chromium.org,sky@chromium.org,inferno@chromium.org,aarya@google.com,dyen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=514815, 566291, 568628

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -124 lines) Patch
M components/mus/gles2/command_buffer_local.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/gles2/command_buffer_local.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/common/gpu/client/command_buffer_proxy_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/gpu/client/command_buffer_proxy_impl.cc View 4 chunks +3 lines, -20 lines 0 comments Download
M content/common/gpu/client/gpu_channel_host.h View 2 chunks +1 line, -3 lines 0 comments Download
M content/common/gpu/client/gpu_channel_host.cc View 2 chunks +1 line, -15 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M gpu/command_buffer/client/client_test_helper.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest.cc View 4 chunks +2 lines, -8 lines 0 comments Download
M gpu/command_buffer/client/gpu_control.h View 1 chunk +1 line, -5 lines 0 comments Download
M gpu/command_buffer/common/constants.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/common/sync_token.h View 6 chunks +0 lines, -15 lines 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.cc View 6 chunks +5 lines, -12 lines 0 comments Download
M gpu/command_buffer/service/mailbox_manager_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/tests/gl_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/tests/gl_manager.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/gles2_conform_support/egl/display.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/gles2_conform_support/egl/display.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/ipc/gpu_command_buffer_traits.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/video_frame_unittest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M mojo/converters/surfaces/surfaces_type_converters.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/gles2/command_buffer_client_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/gles2/command_buffer_client_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ppapi/proxy/ppapi_command_buffer_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/proxy/ppapi_command_buffer_proxy.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/ipc_fuzzer/fuzzer/fuzzer.cc View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
johnme
Created Revert of Reland "Added an extra sync token field for extra command buffer..."
5 years ago (2015-12-10 16:48:43 UTC) #1
johnme
5 years ago (2015-12-10 16:54:20 UTC) #3
Message was sent while issue was closed.
Cancelled revert - I'm no longer convinced this is the cause.

Powered by Google App Engine
This is Rietveld 408576698