Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 1516753007: Remove wasm compile time option and enable wasm behind a runtime flag. (Closed)

Created:
5 years ago by bradn
Modified:
5 years ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove wasm compile time option and enable wasm behind a runtime flag. R=titzer@chromium.org BUG= Committed: https://crrev.com/153f2bd47cce9d5dfa74074dda34c02731d96924 Cr-Commit-Position: refs/heads/master@{#32955}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : fixes #

Patch Set 4 : fix more #

Patch Set 5 : fix #

Patch Set 6 : fix #

Patch Set 7 : git cl try #

Patch Set 8 : fixed #

Patch Set 9 : fix #

Patch Set 10 : fix #

Patch Set 11 : fi #

Patch Set 12 : fix #

Patch Set 13 : fix #

Patch Set 14 : unsigned #

Patch Set 15 : fix #

Patch Set 16 : fix leak #

Patch Set 17 : fix #

Patch Set 18 : fix #

Patch Set 19 : fix #

Patch Set 20 : fix #

Patch Set 21 : fix #

Patch Set 22 : tweak #

Patch Set 23 : tweak #

Patch Set 24 : tweak #

Patch Set 25 : fix #

Patch Set 26 : fix #

Patch Set 27 : merge #

Patch Set 28 : fix #

Patch Set 29 : fix #

Patch Set 30 : fix #

Patch Set 31 : fix #

Patch Set 32 : fix #

Patch Set 33 : fix #

Patch Set 34 : fix #

Patch Set 35 : git cl try #

Patch Set 36 : merge #

Patch Set 37 : external #

Patch Set 38 : fix #

Patch Set 39 : fix #

Patch Set 40 : fix #

Patch Set 41 : fix #

Patch Set 42 : fix #

Patch Set 43 : fix #

Patch Set 44 : fix #

Patch Set 45 : fix #

Patch Set 46 : fix #

Patch Set 47 : fix #

Patch Set 48 : fix #

Patch Set 49 : fix #

Patch Set 50 : merge #

Patch Set 51 : fix #

Patch Set 52 : merge #

Patch Set 53 : fix #

Patch Set 54 : back to the start state #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -64 lines) Patch
M BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 2 chunks +21 lines, -0 lines 0 comments Download
M Makefile View 1 chunk +0 lines, -6 lines 0 comments Download
M build/features.gypi View 2 chunks +0 lines, -6 lines 0 comments Download
M src/bootstrapper.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 2 chunks +0 lines, -6 lines 0 comments Download
M src/d8.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/cctest.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 2 chunks +3 lines, -7 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 3 chunks +23 lines, -3 lines 0 comments Download
M test/unittests/unittests.gyp View 2 chunks +4 lines, -8 lines 0 comments Download
M tools/gyp/v8.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 3 chunks +21 lines, -25 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
bradn
I gather you have a dup of this? I many kicked it up to see ...
5 years ago (2015-12-11 13:45:00 UTC) #1
titzer
On 2015/12/11 13:45:00, bradn wrote: > I gather you have a dup of this? > ...
5 years ago (2015-12-11 13:47:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1516753007/1050001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1516753007/1050001
5 years ago (2015-12-17 16:03:19 UTC) #5
commit-bot: I haz the power
Committed patchset #54 (id:1050001)
5 years ago (2015-12-17 16:04:39 UTC) #6
commit-bot: I haz the power
Patchset 54 (id:??) landed as https://crrev.com/153f2bd47cce9d5dfa74074dda34c02731d96924 Cr-Commit-Position: refs/heads/master@{#32955}
5 years ago (2015-12-17 16:05:05 UTC) #8
Michael Achenbach
5 years ago (2015-12-17 17:58:30 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #54 id:1050001) has been created in
https://codereview.chromium.org/1531073003/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Some build failures, e.g.:
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20shared/build....

Powered by Google App Engine
This is Rietveld 408576698