Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issue 1516753006: [turbofan] Some more cleanup on the intrinsics. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Some more cleanup on the intrinsics. Remove unused obsolete %_StringGetStringLength intrinsic, and properly optimize the %_SubString, %_RegExpExec, %_RegExpFlags, %_RegExpSource and %_RegExpConstructResult intrinsics. Committed: https://crrev.com/7e5ff19ee2b6e9174ccd06bbaf7e4963cf8d4212 Cr-Commit-Position: refs/heads/master@{#32782}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -88 lines) Patch
M src/code-factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/code-factory.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M src/compiler/access-builder.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/access-builder.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.h View 3 chunks +8 lines, -1 line 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 6 chunks +59 lines, -19 lines 0 comments Download
M src/compiler/linkage.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/crankshaft/hydrogen.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +29 lines, -30 lines 0 comments Download
M src/runtime/runtime-strings.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M test/unittests/compiler/js-intrinsic-lowering-unittest.cc View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Benedikt Meurer
Hey Jaro, Some obvious cleanups to the intrinsics. Please take a look. Thanks, Benedikt
5 years ago (2015-12-11 08:32:30 UTC) #2
Jarin
lgtm
5 years ago (2015-12-11 08:55:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1516753006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1516753006/1
5 years ago (2015-12-11 09:01:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-11 09:11:30 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-11 09:12:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e5ff19ee2b6e9174ccd06bbaf7e4963cf8d4212
Cr-Commit-Position: refs/heads/master@{#32782}

Powered by Google App Engine
This is Rietveld 408576698