Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1982)

Unified Diff: public/platform/WebCrypto.h

Issue 151673005: Add digestSynchronous WebCrypto method. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/platform/WebCrypto.h
diff --git a/public/platform/WebCrypto.h b/public/platform/WebCrypto.h
index 998a2153ec8165ddf0a17896085ff8d2873a2920..0d6f1cfa742cc03db0d8ae941a000c84626b46fe 100644
--- a/public/platform/WebCrypto.h
+++ b/public/platform/WebCrypto.h
@@ -178,6 +178,15 @@ public:
// It is possible that unwrappedKeyAlgorithm.isNull()
virtual void unwrapKey(WebCryptoKeyFormat, const unsigned char* wrappedKey, unsigned wrappedKeySize, const WebCryptoKey&, const WebCryptoAlgorithm& unwrapAlgorithm, const WebCryptoAlgorithm& unwrappedKeyAlgorithm, bool extractable, WebCryptoKeyUsageMask, WebCryptoResult result) { result.completeWithError(); }
+ // This is the one exception to the "Completeing the request" guarantees
eroman 2014/02/08 00:03:40 typo completing
jww 2014/02/08 00:41:55 Done.
+ // outlined above. digestSynchronous must provide the result synchronously.
+ // Consumers may assume that the result object will have one of its
+ // "complete" functions called before digestSynchronous returns.
+ //
+ // This is useful for Blink internal crypto and is not part of the
+ // WebCrypto standard.
+ virtual void digestSynchronous(const WebCryptoAlgorithm&, const unsigned char* data, unsigned dataSize, WebCryptoResult result) { result.completeWithError(); }
eroman 2014/02/08 00:03:40 Is it going to be convenient enough having "WebCry
jww 2014/02/08 00:41:55 That works for me. I was trying to keep the API si
+
protected:
virtual ~WebCrypto() { }
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698