third_party/WebKit/Source/platform/scroll/Scrollbar.cpp - Issue 1516723003: [Element / Autofill] Add boundsInViewportFloat() to fix <input> popup misalignment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/Scrollbar.cpp

Issue 1516723003: [Element / Autofill] Add boundsInViewportFloat() to fix <input> popup misalignment. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Refator to use boundsInViewportFloat() eventually, but keep boundsInViewportInt(). Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/platform/scroll/Scrollbar.cpp

diff --git a/third_party/WebKit/Source/platform/scroll/Scrollbar.cpp b/third_party/WebKit/Source/platform/scroll/Scrollbar.cpp

index fefe8750299b9e565ceba32c4500b9547116a41d..cb77597ec8faa0ef495139aea6f0f023df9c9627 100644

--- a/third_party/WebKit/Source/platform/scroll/Scrollbar.cpp

+++ b/third_party/WebKit/Source/platform/scroll/Scrollbar.cpp

@@ -534,6 +534,14 @@ IntRect Scrollbar::convertFromContainingWidget(const IntRect& parentRect) const

return Widget::convertFromContainingWidget(parentRect);

}

+FloatRect Scrollbar::convertToContainingWidget(const FloatRect& localRect) const

+ if (m_scrollableArea)

+ return m_scrollableArea->convertFromScrollbarToContainingWidget(this, localRect);

+ return Widget::convertToContainingWidget(localRect);

IntPoint Scrollbar::convertToContainingWidget(const IntPoint& localPoint) const

{

if (m_scrollableArea)

« no previous file with comments | « third_party/WebKit/Source/platform/scroll/Scrollbar.h ('k') | third_party/WebKit/Source/web/WebElement.cpp » ('j') | no next file with comments »