third_party/WebKit/Source/core/input/EventHandler.cpp - Issue 1516723003: [Element / Autofill] Add boundsInViewportFloat() to fix <input> popup misalignment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/input/EventHandler.cpp

Issue 1516723003: [Element / Autofill] Add boundsInViewportFloat() to fix <input> popup misalignment. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Refator to use boundsInViewportFloat() eventually, but keep boundsInViewportInt(). Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/input/EventHandler.cpp

diff --git a/third_party/WebKit/Source/core/input/EventHandler.cpp b/third_party/WebKit/Source/core/input/EventHandler.cpp

index e18894fb9057d571d5e348c36482c92de538ced8..88ac09c925deb6dee8f3966aa073b9c0e16d1b62 100644

--- a/third_party/WebKit/Source/core/input/EventHandler.cpp

+++ b/third_party/WebKit/Source/core/input/EventHandler.cpp

@@ -2976,7 +2976,7 @@ WebInputEventResult EventHandler::sendContextMenuEventForKey(Element* overrideTa

int y = firstRect.maxY() ? firstRect.maxY() - 1 : 0;

locationInRootFrame = view->contentsToRootFrame(IntPoint(x, y));

} else if (focusedElement) {

- IntRect clippedRect = focusedElement->boundsInViewport();

+ IntRect clippedRect = focusedElement->boundsInViewportInt();

locationInRootFrame = visualViewport.viewportToRootFrame(clippedRect.center());

} else {

locationInRootFrame = IntPoint(

« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.cpp ('k') | third_party/WebKit/Source/platform/Widget.h » ('j') | no next file with comments »