content/renderer/pepper/pepper_plugin_instance_impl.cc - Issue 1516723003: [Element / Autofill] Add boundsInViewportFloat() to fix <input> popup misalignment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/pepper_plugin_instance_impl.cc

Issue 1516723003: [Element / Autofill] Add boundsInViewportFloat() to fix <input> popup misalignment. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Refator to use boundsInViewportFloat() eventually, but keep boundsInViewportInt(). Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/pepper/pepper_plugin_instance_impl.cc

diff --git a/content/renderer/pepper/pepper_plugin_instance_impl.cc b/content/renderer/pepper/pepper_plugin_instance_impl.cc

index d23f9f967155d5914748d97d8b3376813fc85bfa..663e400be81ef8fc02ae96b8ed8353ba60a3717d 100644

--- a/content/renderer/pepper/pepper_plugin_instance_impl.cc

+++ b/content/renderer/pepper/pepper_plugin_instance_impl.cc

@@ -1079,7 +1079,7 @@ bool PepperPluginInstanceImpl::HandleInputEvent(

event.type == blink::WebInputEvent::MouseDown &&

(event.modifiers & blink::WebInputEvent::LeftButtonDown)) {

has_been_clicked_ = true;

- blink::WebRect bounds = container()->element().boundsInViewport();

+ blink::WebRect bounds = container()->element().boundsInViewportInt();

RecordFlashClickSizeMetric(bounds.width, bounds.height);

}

« no previous file with comments | « content/public/renderer/render_view.h ('k') | content/renderer/render_view_impl.h » ('j') | no next file with comments »