chrome/browser/ui/autofill/popup_controller_common.cc - Issue 1516723003: [Element / Autofill] Add boundsInViewportFloat() to fix <input> popup misalignment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/popup_controller_common.cc

Issue 1516723003: [Element / Autofill] Add boundsInViewportFloat() to fix <input> popup misalignment. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Refator to use boundsInViewportFloat() eventually, but keep boundsInViewportInt(). Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/autofill/popup_controller_common.cc

diff --git a/chrome/browser/ui/autofill/popup_controller_common.cc b/chrome/browser/ui/autofill/popup_controller_common.cc

index 0bf73db64841bdf98b998e4565830b478051f5e1..ae5f6bdd9c9cb316bf74d5409b18f2823afaa4d8 100644

--- a/chrome/browser/ui/autofill/popup_controller_common.cc

+++ b/chrome/browser/ui/autofill/popup_controller_common.cc

@@ -60,7 +60,7 @@ gfx::Display PopupControllerCommon::GetDisplayNearestPoint(

}

const gfx::Rect PopupControllerCommon::RoundedElementBounds() const {

- return gfx::ToEnclosingRect(element_bounds_);

+ return gfx::ToNearestRect(element_bounds_);

}

std::pair<int, int> PopupControllerCommon::CalculatePopupXAndWidth(

« no previous file with comments | « no previous file | components/autofill/content/renderer/autofill_agent.cc » ('j') | no next file with comments »