[Element / Autofill] Add boundsInViewportFloat() to fix <input> popup misalignment.

third_party/WebKit/Source/core/dom/Element.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Peter Kelly (pmk@post.com)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2007 David Smith (catfish.man@gmail.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
  *           (C) 2007 Eric Seidel (eric@webkit.org)
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 995 matching lines @@
 
 bool Element::hasNonEmptyLayoutSize() const
 {
     document().updateLayoutIgnorePendingStylesheets();
 
     if (LayoutBoxModelObject* box = layoutBoxModelObject())
         return box->hasNonEmptyLayoutSize();
     return false;
 }
 
-IntRect Element::boundsInViewport()
+bool Element::getBoundingQuads(Vector<FloatQuad>& quads)
 {
-    document().updateLayoutIgnorePendingStylesheets();
-
-    FrameView* view = document().view();
-    if (!view)
-        return IntRect();
-
-    Vector<FloatQuad> quads;
+    assert(quads.isEmpty());
     if (isSVGElement() && layoutObject()) {
         // Get the bounding rectangle from the SVG model.
         if (toSVGElement(this)->isSVGGraphicsElement())
             quads.append(layoutObject()->localToAbsoluteQuad(layoutObject()->objectBoundingBox()));
     } else {
         // Get the bounding rectangle from the box model.
         if (layoutBoxModelObject())
             layoutBoxModelObject()->absoluteQuads(quads);
     }
+    return !quads.isEmpty();
+}
 
-    if (quads.isEmpty())
+IntRect Element::boundsInViewport()
+{
+    document().updateLayoutIgnorePendingStylesheets();
+
+    FrameView* view = document().view();
+    if (!view)
+        return IntRect();
+
+    Vector<FloatQuad> quads;
+    if (!getBoundingQuads(quads))
         return IntRect();
 
     IntRect result = quads[0].enclosingBoundingBox();
     for (size_t i = 1; i < quads.size(); ++i)
         result.unite(quads[i].enclosingBoundingBox());
 
     return view->contentsToViewport(result);
 }
 
+FloatRect Element::boundsInViewportFloat()

[bokan, 2015/12/10 14:48:39]

Perhaps we should just make boundsInViewport return a FloatRect, rather then add
a second method, and let call sites truncate to ints

[huangs, 2015/12/10 16:16:14]

Replied in main comment.

+{
+    document().updateLayoutIgnorePendingStylesheets();
+
+    FrameView* view = document().view();
+    if (!view)
+        return FloatRect();
+
+    Vector<FloatQuad> quads;
+    if (!getBoundingQuads(quads))
+        return FloatRect();
+
+    FloatRect result = quads[0].boundingBox();
+    for (size_t i = 1; i < quads.size(); ++i)
+        result.unite(quads[i].boundingBox());
+
+    return view->contentsToViewport(result);
+}
+
 ClientRectList* Element::getClientRects()
 {
     document().updateLayoutIgnorePendingStylesheets();
 
     LayoutObject* elementLayoutObject = layoutObject();
     if (!elementLayoutObject || (!elementLayoutObject->isBoxModelObject() && !elementLayoutObject->isBR()))
         return ClientRectList::create();
 
     // FIXME: Handle SVG elements.
     // FIXME: Handle table/inline-table with a caption.
@@ skipping 2576 matching lines @@
 {
 #if ENABLE(OILPAN)
     if (hasRareData())
         visitor->trace(elementRareData());
     visitor->trace(m_elementData);
 #endif
     ContainerNode::trace(visitor);
 }
 
 } // namespace blink