Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1516683007: Remove code duplication in GPU command buffer. (Closed)

Created:
5 years ago by Zhenyao Mo
Modified:
5 years ago
Reviewers:
bajones
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove code duplication in GPU command buffer. BUG=563714 TEST=gpu_unittests R=bajones@chromium.org Committed: https://crrev.com/fba8249fae7e6ff4de6adc2cf3f8c8eee28364eb Cr-Commit-Position: refs/heads/master@{#364803}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -34 lines) Patch
M gpu/command_buffer/common/gles2_cmd_utils.cc View 1 chunk +5 lines, -34 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Zhenyao Mo
bajones: PTAL
5 years ago (2015-12-11 18:53:44 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1516683007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1516683007/1
5 years ago (2015-12-11 18:55:10 UTC) #3
bajones
LGTM
5 years ago (2015-12-11 18:58:16 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-11 20:30:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1516683007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1516683007/1
5 years ago (2015-12-11 20:37:52 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-11 21:14:51 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-11 21:17:11 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fba8249fae7e6ff4de6adc2cf3f8c8eee28364eb
Cr-Commit-Position: refs/heads/master@{#364803}

Powered by Google App Engine
This is Rietveld 408576698