Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1516683003: Fix GN label names for blink_heap_unittests, blink_platform_unittests. (Closed)

Created:
5 years ago by Dirk Pranke
Modified:
5 years ago
Reviewers:
brettw
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-api_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix GN label names for blink_heap_unittests, blink_platform_unittests. The GN convention for test binaries is to have the label name match the output name where possible, so this patch renames :heap_unittests to :blink_heap_unittests and :platform_unittests to :blink_platform_unittests. This fixes various build errors encountered in flipping the blink bots to GN. TBR=brettw@chromium.org BUG=432959 Committed: https://chromium.googlesource.com/chromium/src/+/49802733e29439008adf2cfcf915c34071ce9c6b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -14 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/49802733e29439008adf2cfcf915c34071ce9c6b Cr-Commit-Position: refs/heads/master@{#364246}
5 years ago (2015-12-10 01:38:16 UTC) #2
Dirk Pranke
Committed patchset #1 (id:1) manually as 49802733e29439008adf2cfcf915c34071ce9c6b (presubmit successful).
5 years ago (2015-12-10 01:38:47 UTC) #4
brettw
5 years ago (2015-12-10 17:49:49 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698