third_party/WebKit/Source/core/layout/LayoutObject.h - Issue 1516683002: Introducing LayoutObject::mapToVisibleRectInContainerSpace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.h

Issue 1516683002: Introducing LayoutObject::mapToVisibleRectInContainerSpace (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Fix flipping logic Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutListMarker.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutObject.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.h b/third_party/WebKit/Source/core/layout/LayoutObject.h

index 709f3bba05d33abb9efaceb114c0ba7a0e2ce02f..c256aafb9ba10a158961d40d57b22bc607092993 100644

--- a/third_party/WebKit/Source/core/layout/LayoutObject.h

+++ b/third_party/WebKit/Source/core/layout/LayoutObject.h

@@ -1083,9 +1083,11 @@ public:

virtual LayoutRect absoluteClippedOverflowRect() const;

virtual LayoutRect clippedOverflowRectForPaintInvalidation(const LayoutBoxModelObject* paintInvalidationContainer, const PaintInvalidationState* = nullptr) const;

- // Given a rect in the object's coordinate space, compute a rect suitable for invalidating paints of

- // that rect in the coordinate space of paintInvalidationContainer.

- virtual void mapRectToPaintInvalidationBacking(const LayoutBoxModelObject* paintInvalidationContainer, LayoutRect&, const PaintInvalidationState*) const;

+ // Given a rect in the object's coordinate space, compute a rect suitable for invalidating paints of that

+ // rect in the coordinate space of paintInvalidationContainer. If intermediate containers have clipping or

+ // scrolling of any kind, it is applied; but overflow clipping is *not* applied for paintInvalidationContainer

+ // itself.

+ virtual void mapToVisibleRectInContainerSpace(const LayoutBoxModelObject* paintInvalidationContainer, LayoutRect&, const PaintInvalidationState*) const;

// Return the offset to the column in which the specified point (in flow-thread coordinates)

// lives. This is used to convert a flow-thread point to a visual point.